Fix useLogs after review

Author: jscheffl

airflow-core/src/airflow/ui/src/pages/Dag/Overview/TaskLogPreview.tsx

@@ -17,7 +17,6 @@
  * under the License.
  */
 import { Box, Flex, Link } from "@chakra-ui/react";
-import { useTranslation } from "react-i18next";
 import { Link as RouterLink } from "react-router-dom";
 
 import type { TaskInstanceResponse } from "openapi/requests/types.gen";
@@ -35,13 +34,11 @@ export const TaskLogPreview = ({
   readonly taskInstance: TaskInstanceResponse;
   readonly wrap: boolean;
 }) => {
-  const { t: translate } = useTranslation();
   const { data, error, isLoading } = useLogs(
     {
       dagId: taskInstance.dag_id,
       logLevelFilters: ["error", "critical"],
       taskInstance,
-      translate,
       tryNumber: taskInstance.try_number,
     },
     {

airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx

@@ -19,7 +19,6 @@
 import { Box, Heading, VStack } from "@chakra-ui/react";
 import { useState } from "react";
 import { useHotkeys } from "react-hotkeys-hook";
-import { useTranslation } from "react-i18next";
 import { useParams, useSearchParams } from "react-router-dom";
 
 import { useTaskInstanceServiceGetMappedTaskInstance } from "openapi/queries";
@@ -33,7 +32,6 @@ import { TaskLogContent } from "./TaskLogContent";
 import { TaskLogHeader } from "./TaskLogHeader";
 
 export const Logs = () => {
-  const { t: translate } = useTranslation();
   const { dagId = "", mapIndex = "-1", runId = "", taskId = "" } = useParams();
   const [searchParams, setSearchParams] = useSearchParams();
 
@@ -87,7 +85,6 @@ export const Logs = () => {
     logLevelFilters,
     sourceFilters,
     taskInstance,
-    translate,
     tryNumber: tryNumber === 0 ? 1 : tryNumber,
   });
 

airflow-core/src/airflow/ui/src/queries/useLogs.tsx

@@ -20,6 +20,7 @@ import { chakra } from "@chakra-ui/react";
 import type { UseQueryOptions } from "@tanstack/react-query";
 import dayjs from "dayjs";
 import type { TFunction } from "i18next";
+import { useTranslation } from "react-i18next";
 import innerText from "react-innertext";
 
 import { useTaskInstanceServiceGetLog } from "openapi/queries";
@@ -34,7 +35,6 @@ type Props = {
   logLevelFilters?: Array<string>;
   sourceFilters?: Array<string>;
   taskInstance?: TaskInstanceResponse;
-  translate: TFunction;
   tryNumber?: number;
 };
 
@@ -138,17 +138,10 @@ const parseLogs = ({
 };
 
 export const useLogs = (
-  {
-    accept = "application/json",
-    dagId,
-    logLevelFilters,
-    sourceFilters,
-    taskInstance,
-    translate,
-    tryNumber = 1,
-  }: Props,
+  { accept = "application/json", dagId, logLevelFilters, sourceFilters, taskInstance, tryNumber = 1 }: Props,
   options?: Omit<UseQueryOptions<TaskInstancesLogResponse>, "queryFn" | "queryKey">,
 ) => {
+  const { t: translate } = useTranslation("common");
   const refetchInterval = useAutoRefresh({ dagId });
 
   const { data, ...rest } = useTaskInstanceServiceGetLog(