Skip to content

Fix patch_task_instance endpoint #50550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented May 13, 2025

Update spec for the patch_task_instance_endpoint. This is necessary to be able to handle in the future task instance summaries (all the map_indexes for a given TI) and task groups.

This fell through the cracks and need to be fixed.

@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.2 milestone May 13, 2025
@pierrejeambrun pierrejeambrun self-assigned this May 13, 2025
@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label May 13, 2025
@pierrejeambrun pierrejeambrun added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label May 13, 2025
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels May 13, 2025
@pierrejeambrun pierrejeambrun force-pushed the update-patch-task-instance-return-type branch from 5c447cf to 39cd8c7 Compare May 13, 2025 16:39
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


Follow up:

I think we can extract the map_index query parameter into a common parameter class to handle the logic:
map_index = -1 if map_index is None else map_index directly in the router.

I'll raise a follow-up PR after this one is merged.

@pierrejeambrun
Copy link
Member Author

This was just to limit the PR to the change spec, but with #50526 this lines won't exist anymore. (None will be handled as summary)

@pierrejeambrun pierrejeambrun merged commit db89cc0 into apache:main May 14, 2025
2 checks passed
@pierrejeambrun pierrejeambrun deleted the update-patch-task-instance-return-type branch May 14, 2025 08:46
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker db89cc0 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

pierrejeambrun added a commit to astronomer/airflow that referenced this pull request May 14, 2025
kaxil pushed a commit to astronomer/airflow that referenced this pull request May 14, 2025
pierrejeambrun added a commit that referenced this pull request May 14, 2025
* Fix patch_task_instance endpoint (#50550)

(cherry picked from commit db89cc0)

* Fix CI
kaxil pushed a commit that referenced this pull request Jun 3, 2025
* Fix patch_task_instance endpoint (#50550)

(cherry picked from commit db89cc0)

* Fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants