-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Fix patch_task_instance endpoint #50550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix patch_task_instance endpoint #50550
Conversation
5c447cf
to
39cd8c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Follow up:
I think we can extract the map_index
query parameter into a common parameter class to handle the logic:
map_index = -1 if map_index is None else map_index
directly in the router.
I'll raise a follow-up PR after this one is merged.
This was just to limit the PR to the change spec, but with #50526 this lines won't exist anymore. (None will be handled as summary) |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker db89cc0 v3-0-test This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
(cherry picked from commit db89cc0)
(cherry picked from commit db89cc0)
Update spec for the
patch_task_instance_endpoint
. This is necessary to be able to handle in the future task instance summaries (all the map_indexes for a given TI) and task groups.This fell through the cracks and need to be fixed.