Skip to content

Add Patch Task Instance Summary #50526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented May 13, 2025

related to: #48584

Update the patch_task_instance_dry_run and patch_task_instance endpoints to handle ti summaries(i.e mapped TI without specifying the map_index => all of them will be affected). Default value is changed toNonebut it will not break because it supersede the-1` for unmapped tasks.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels May 13, 2025
@pierrejeambrun pierrejeambrun force-pushed the patch-task-instance-summary branch from 3f37926 to d31279c Compare May 13, 2025 08:41
@pierrejeambrun
Copy link
Member Author

Following discussion with Brent, we should probably also support task group there.

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.0 milestone May 13, 2025
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented May 13, 2025

When we will want to incorporate task groups we will encounter the same problem, we will not be able to update the patch_task_instance_endpoint.

I feel like maybe we update it (change the return type) as a bugfix because we will not be able to handle summary and task_group otherwise.

Note to self: task_group_dict get_task_group_children

@bbovenzi
Copy link
Contributor

I'm ok with calling the change a bug fix. We supported this in the old UI but it fell through the cracks in 3.0.0

@potiuk potiuk added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label May 13, 2025
@pierrejeambrun
Copy link
Member Author

#50550 PR for the endpoint spec fix. That can be targeted for 3.0.2. I'll update this PR to use that then, and target 3.1.0 for the ability to clear mapped task instances as a whole. (all mapped index)

@pierrejeambrun pierrejeambrun marked this pull request as draft May 13, 2025 16:41
@pierrejeambrun
Copy link
Member Author

Do not merge, need to be updated once #50550 is merged

@pierrejeambrun pierrejeambrun removed the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label May 14, 2025
@pierrejeambrun pierrejeambrun force-pushed the patch-task-instance-summary branch from d31279c to b76da2e Compare May 14, 2025 16:33
@pierrejeambrun pierrejeambrun force-pushed the patch-task-instance-summary branch from b76da2e to 836cabf Compare May 14, 2025 16:37
@pierrejeambrun pierrejeambrun marked this pull request as ready for review May 14, 2025 16:42
@pierrejeambrun
Copy link
Member Author

I need to update the PR description before merging

@pierrejeambrun pierrejeambrun merged commit a41a8bd into apache:main May 15, 2025
95 checks passed
@pierrejeambrun pierrejeambrun deleted the patch-task-instance-summary branch May 15, 2025 10:04
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Add Patch Task Instance Summary

* Test small adjustment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants