Skip to content

MWPW-176184 [MEP] Inline fragments created by MEP should not have a paragraph wrap #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from
+4 −2
Open

MWPW-176184 [MEP] Inline fragments created by MEP should not have a paragraph wrap #4530

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
616197f
Fix inline content rendering by conditionally creating link or paragr…
vgoodric Jul 7, 2025
8fb9758
Fix inline content handling by adjusting tag creation logic
vgoodric Jul 9, 2025
d3a0d20
Merge branch 'stage' into buttononnewlinebug
vgoodric Jul 9, 2025
e9b6a70
Fix: update paragraph wrapping logic in createFrag function
vgoodric Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libs/features/personalization/personalization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ const createFrag = (el, action, content, manifestId, targetManifestId) => {
}
const a = createTag('a', { href }, content);
addIds(a, manifestId, targetManifestId);
const frag = createTag('p', undefined, a);
const noParagraphWrap = !!el?.parentElement?.closest('p')
|| (el.nodeName === 'P' && action.includes('pend'));
const frag = noParagraphWrap ? a : createTag('p', undefined, a);
const isDelayedModalAnchor = /#.*delay=/.test(href);
if (isDelayedModalAnchor) frag.classList.add('hide-block');
if (isInLcpSection(el)) {
Expand Down Expand Up @@ -634,7 +636,7 @@ export function handleCommands(
const insertAnchor = getSelectorType(selector) === 'fragment' ? el.parentElement : el;
insertAnchor?.insertAdjacentElement(
CREATE_CMDS[action],
createContent(el, cmd),
createContent(insertAnchor, cmd),
);
});
if ((els.length && !cmd.modifiers.includes(FLAGS.all))
Expand Down
Loading