-
Notifications
You must be signed in to change notification settings - Fork 192
MWPW-176184 [MEP] Inline fragments created by MEP should not have a paragraph wrap #4530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve; I used both the screenshot tool and my own visual inspection, and I found no problems resulting from this code.
Visually inspected:
https://main--cc--adobecom.aem.live/creativecloud?milolibs=buttononnewlinebug
https://main--cc--adobecom.aem.live/creativecloud/plans?milolibs=buttononnewlinebug
https://main--cc--adobecom.aem.live/creativecloud/photography?milolibs=buttononnewlinebug
https://main--cc--adobecom.aem.live/products/photoshop?milolibs=buttononnewlinebug
https://main--cc--adobecom.aem.live/products/illustrator?milolibs=buttononnewlinebug
https://main--cc--adobecom.aem.live/products/premiere?milolibs=buttononnewlinebug
https://main--cc--adobecom.aem.live/products/catalog?milolibs=buttononnewlinebug
https://main--dc--adobecom.aem.live/acrobat?milolibs=buttononnewlinebug
https://main--dc--adobecom.aem.live/acrobat/features?milolibs=buttononnewlinebug
https://main--homepage--adobecom.aem.live/homepage/index-loggedout?milolibs=buttononnewlinebug
https://main--bacom--adobecom.aem.live/?milolibs=buttononnewlinebug
https://main--bacom--adobecom.aem.live/resources/main?milolibs=buttononnewlinebug
https://main--bacom--adobecom.aem.live/products?milolibs=buttononnewlinebug
Screenshot comparison tool: https://git.corp.adobe.com/marketingtech/milolibs-screenshot-comparison
Detailed Description: When trying to replace a button with an inline fragment, it sometimes puts the new button on a second line.
Cause: Paragraph elements do not support a block-level element nested inside of it. But it does allow you to insert one via javascript. However, if you try to update innerHTML to have a nested paragraph in a paragraph, the browser will THEN fix the malformed HTML. The result, inline fragments can be inserted in a paragraph, but will be moved if the HTML is processed for placeholders.
................................
URL: https://main--cc--adobecom.aem.page/drafts/mepdev/fragments/2025/q3/buttononnewlinebug/reduced
................................
Steps to Reproduce:
Expected Results: buttons in yellow blade (section 2) should be side by side
................................
Actual Results: buttons are stacked and offset
Resolves: MWPW-NUMBER
Test URLs: