Skip to content

MWPW-176184 [MEP] Inline fragments created by MEP should not have a paragraph wrap #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from

Conversation

vgoodric
Copy link
Contributor

@vgoodric vgoodric commented Jul 9, 2025

Detailed Description: When trying to replace a button with an inline fragment, it sometimes puts the new button on a second line.

Cause: Paragraph elements do not support a block-level element nested inside of it. But it does allow you to insert one via javascript. However, if you try to update innerHTML to have a nested paragraph in a paragraph, the browser will THEN fix the malformed HTML. The result, inline fragments can be inserted in a paragraph, but will be moved if the HTML is processed for placeholders.
................................
URL: https://main--cc--adobecom.aem.page/drafts/mepdev/fragments/2025/q3/buttononnewlinebug/reduced
................................
Steps to Reproduce:

  1. Go to URL

Expected Results: buttons in yellow blade (section 2) should be side by side
................................
Actual Results: buttons are stacked and offset

Resolves: MWPW-NUMBER

Test URLs:

@vgoodric vgoodric requested a review from a team as a code owner July 9, 2025 21:58
Copy link
Contributor

aem-code-sync bot commented Jul 9, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jul 9, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@jpratt2 jpratt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vgoodric vgoodric added verified PR has been E2E tested by a reviewer Ready for Stage labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants