Add Terms Query container block #70720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
New Block
mikachan
requested review from
spacedmonkey,
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.16 kB (+0.06%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
@mikachan Are we sure that we want to utilize the I'm also not sure how the query arg |
Ah I see, in that case I think something like
Yes, these are essentially the same display option, and they can probably be consolidated. I was using |
scruffian
reviewed
Jul 31, 2025
|
|
||
| return ( | ||
| <> | ||
| <InspectorControls> |
There was a problem hiding this comment.
Why not put InspectorControls inside the TermsQueryInspectorControls component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #49094.
This adds a new container block called Terms Query, similar to the Query block but for terms rather than posts. This can be tested as part of a larger PR at #70682. It is designed to contain a new Terms Template block, which can then hold inner blocks for displaying each term.
I haven't created a Core backport PR yet as I'm not sure if this is the right approach for this block. I'll make sure to open one before this PR is merged.
Why?
To allow for more options and flexibility when displaying terms.
How?
This block allows for inner blocks and has a wider potential for extensibility compared to the Categories/Terms List block.
I've tried to keep the implementation as simple as possible so we can build up the functionality as we add the other blocks. For the inspector controls, I've tried to stay as close as possible to the options provided by the Categories List block.
Testing Instructions
This block is difficult to test in isolation, so a working example can be seen in #70682. This block doesn't really do anything on its own other than provide some block settings for the terms query.
For this first PR:
Screenshots or screencast