Add Terms Query block #70682
Draft
Add Terms Query block #70682
+1,935
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
New Block
|
Size Change: +3.23 kB (+0.17%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a632e42. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16217777071
|
|
To avoid redundant contributions I'll be contributing to this PR directly. I'll add the following features:
Apart from these changes the rest of my code seems to be pretty much same. |
|
I've started splitting this up into smaller PRs starting with the Terms Query block: #70720. I think we can still use this draft PR to test the other functionality, as it's easier to test ideas out when all the blocks are together. |
|
Hey @mikachan, would it be possible for you to make the changes mentioned here — #70747 (comment) — in this PR as well? |
|
@sarthaknagoshe2002 Yes sure, done in 05ba6d1. |
|
This is looking great, thanks for working on it.
The one thing missing that I can see is that this block doesn't have an option to display as dropdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #49094
WIP
This adds a new block called Terms Query, to allow for a more flexible and extensible block for displaying taxonomy terms. It also adds a couple of inner blocks, Term Name and Term Count.
This PR is just a proof of concept, as I think this functionality will be easier to work on and review if it's split up into smaller PRs. More details in #49094.
Why?
To allow for more options and flexibility when displaying terms.
How?
This block allows for inner blocks and has a wider potential for extensibility compared to the Categories/Terms List block. This PR includes four new blocks:
It also allows Term Description as an inner block.
I've tried to match the functionality as closely as possible with the Categories block for now, and then we can add more options as follow-ups. Here are some ideas I've been thinking of:
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast