Skip to content

Add gz_frame_id's to sensors #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TannerGilbert
Copy link

Adds gz_frame_id to sensors to ensure the ROS topics have the correct frame_id.

@dakejahl
Copy link
Contributor

Thanks. We will need to come back to this and rename to frame_id once it's fully removed

See gazebosim/sdformat#1454 for details

Ardupilot does this ArduPilot/ardupilot_gazebo#131

Signed-off-by: Tanner, Gilbert <[email protected]>
@TannerGilbert
Copy link
Author

@dakejahl thanks for the quick feedback. The formatting of the models is quite different in some files (spaces vs. tabs etc.). I made two commits. The first only updated the rover_ackermann that had the formatting issues you mentioned. The second updates all model files to have consistent formatting which might not be wanted in this PR. Please tell me if it would be more desirable to remove the last commit or not. Best regards, Gilbert

@dakejahl
Copy link
Contributor

Awesome thank you! All of the files are missing newlines and the end and github doesn't like that
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants