-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Open
Labels
Description
Describe the bug
I believe the application of Euler angles is incorrect with the simulated gimbal. According to the SDF file, the order of rotations is yaw, roll, and then pitch. This seems fairly standard with 3-axis gimbals. It corresponds to a ZXY or 312 intrinsic convention. However, the conversion from quaternion to Euler angles in GZGimbal.cpp uses the ZYX or 321 convention per Euler.hpp. I haven't tested extensively, but I would expect this to produce unexpected results.
To Reproduce
No response
Expected behavior
No response
Screenshot / Media
No response
Flight Log
No response
Software Version
No response
Flight controller
No response
Vehicle type
None
How are the different components wired up (including port information)
No response
Additional context
No response