355 convert long num arrays #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 355-convert-long-num-arrays
…into 355-convert-long-num-arrays
pavel-kirienko
requested changes
Jun 16, 2025
| elif len(s) <= 128: | ||
| return _strictify(Natural16(s)) if all(x >= 0 for x in s) else _strictify(Integer16(s)) | ||
| elif len(s) <= 256: | ||
| return _strictify(Natural8(s)) if all(x >= 0 for x in s) else _strictify(Integer8(s)) | ||
| if all(isinstance(x, (float, int, bool)) for x in s): |
There was a problem hiding this comment.
You need either this, or raise an exception in the previous if
Suggested change
| if all(isinstance(x, (float, int, bool)) for x in s): | |
| elif all(isinstance(x, (float, int, bool)) for x in s): |
…ycyphal into 355-convert-long-num-arrays
songmeo
force-pushed
the
355-convert-long-num-arrays
branch
from
40a95de to
6b83cdb
Compare
songmeo
force-pushed
the
355-convert-long-num-arrays
branch
from
6b83cdb to
e83708b
Compare
songmeo
force-pushed
the
355-convert-long-num-arrays
branch
6 times, most recently
from
1d48c12 to
6e8005c
Compare
songmeo
force-pushed
the
355-convert-long-num-arrays
branch
from
6e8005c to
f0992a3
Compare
pavel-kirienko
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #355