Skip to content

build(windows): add arm64 build #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Nov 3, 2024

Description

This PR adds an arm64 build for Windows.

Todo:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.51%. Comparing base (ef5253a) to head (3924992).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #3369     +/-   ##
=========================================
  Coverage   11.51%   11.51%             
=========================================
  Files          92       92             
  Lines       17499    17499             
  Branches     8152     8152             
=========================================
  Hits         2015     2015             
- Misses      12988    14885   +1897     
+ Partials     2496      599   -1897     
Flag Coverage Δ
Linux 11.14% <ø> (ø)
Windows ?
Windows-AMD64 12.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/display_base.cpp 35.92% <ø> (ø)

... and 31 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch 2 times, most recently from 863e5b1 to 6b99141 Compare November 3, 2024 23:37
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Nov 3, 2024
Copy link

sonarqubecloud bot commented Nov 3, 2024

@cgutman
Copy link
Collaborator

cgutman commented Nov 7, 2024

The problem is that the clangarm64 toolchain don't just create ARM64 binaries, they are ARM64 binaries. We need an ARM64 runner to run the build.

@ReenigneArcher

This comment was marked as outdated.

@ReenigneArcher ReenigneArcher deleted the build/windows/cross-compile-for-arm branch November 16, 2024 21:28
@ReenigneArcher
Copy link
Member Author

Looks like Windows arm runners might be coming to open source repos soon: https://github.blog/changelog/2024-06-03-actions-arm-based-linux-and-windows-runners-are-now-in-public-beta/

@minzdrav

This comment was marked as resolved.

@ReenigneArcher

This comment was marked as outdated.

@rbqvq

This comment was marked as off-topic.

@ReenigneArcher

This comment was marked as off-topic.

@rbqvq

This comment was marked as resolved.

@rbqvq

This comment was marked as outdated.

@rbqvq
Copy link
Contributor

rbqvq commented May 12, 2025

FFmpeg and other related dependencies have passed the compilation test.
You can download via CI for insider preview.

Let's continue work on it.

@ReenigneArcher ReenigneArcher restored the build/windows/cross-compile-for-arm branch May 12, 2025 12:30
@rbqvq

This comment was marked as outdated.

@rbqvq

This comment was marked as outdated.

@ReenigneArcher
Copy link
Member Author

Sunshine doesn't compile with boost 1.88 yet. Something with boost process was removed

@rbqvq

This comment was marked as outdated.

@rbqvq

This comment was marked as outdated.

@ReenigneArcher
Copy link
Member Author

Probably better to update boost::process::v1 usages instead of dealing with patches.

@rbqvq

This comment was marked as outdated.

@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from 6b99141 to c491dff Compare May 24, 2025 15:09
@ReenigneArcher ReenigneArcher changed the title build(windows): cross compile for arm build(windows): add arm64 build May 24, 2025
@rbqvq

This comment was marked as duplicate.

Copy link

codecov bot commented May 24, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher

This comment was marked as off-topic.

@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from b11bd38 to 4d116a0 Compare May 24, 2025 17:34
@rbqvq

This comment was marked as off-topic.

@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from 4d116a0 to 0dd4218 Compare May 24, 2025 17:47
@rbqvq

This comment was marked as duplicate.

@ReenigneArcher
Copy link
Member Author

Please stop spamming this PR. You can move discussion to discord, thanks.

@LizardByte LizardByte locked and limited conversation to collaborators May 24, 2025
@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from 0dd4218 to 632d48d Compare May 24, 2025 18:15
@LizardByte LizardByte unlocked this conversation May 24, 2025
@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from 632d48d to 3924992 Compare May 24, 2025 19:57
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants