-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
build(windows): add arm64 build #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3369 +/- ##
=========================================
Coverage 11.51% 11.51%
=========================================
Files 92 92
Lines 17499 17499
Branches 8152 8152
=========================================
Hits 2015 2015
- Misses 12988 14885 +1897
+ Partials 2496 599 -1897
Flags with carried forward coverage won't be shown. Click here to find out more.
|
863e5b1
to
6b99141
Compare
|
The problem is that the clangarm64 toolchain don't just create ARM64 binaries, they are ARM64 binaries. We need an ARM64 runner to run the build. |
This comment was marked as outdated.
This comment was marked as outdated.
Looks like Windows arm runners might be coming to open source repos soon: https://github.blog/changelog/2024-06-03-actions-arm-based-linux-and-windows-runners-are-now-in-public-beta/ |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
FFmpeg and other related dependencies have passed the compilation test. Let's continue work on it. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sunshine doesn't compile with boost 1.88 yet. Something with boost process was removed |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Probably better to update |
This comment was marked as outdated.
This comment was marked as outdated.
6b99141
to
c491dff
Compare
13c28db
to
b11bd38
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Bundle ReportBundle size has no change ✅ |
This comment was marked as off-topic.
This comment was marked as off-topic.
b11bd38
to
4d116a0
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
4d116a0
to
0dd4218
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Please stop spamming this PR. You can move discussion to discord, thanks. |
0dd4218
to
632d48d
Compare
632d48d
to
3924992
Compare
|
Description
This PR adds an arm64 build for Windows.
Todo:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist