-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(installer/windows): add wix installer #3916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
14ce5ed
to
f20af0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3916 +/- ##
=========================================
Coverage ? 11.37%
=========================================
Files ? 92
Lines ? 17549
Branches ? 8232
=========================================
Hits ? 1996
Misses ? 13033
Partials ? 2520
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportBundle size has no change ✅ |
9e4b955
to
6ef5e6e
Compare
|
The latest NSIS version now runs properly on ARM64 systems, so we can stick with NSIS if we want. WiX does make it easier to support having a single unified installer for both x64 and ARM64 binaries if we want that. |
Good to know. I still need to setup a VM to test this out. I think msi would still be nice to use, especially for anyone installing Sunshine with a script as it supports more CLI options. I discovered in a recent change that I couldn't even get the output of the installer scripts to a log file with NSIS. Do you know the process for unifying the installer? That would be pretty nice. |
6c352ab
to
f282e5d
Compare
f282e5d
to
1e4a867
Compare
|
Description
This PR adds a WIX installer for Sunshine. The NSIS installer will be removed at a later point after any bugs with the WIX installer are ironed out.
This is a requirement for having an ARM64 installer for #3905 or #3369
TODO:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist