Skip to content

feat(installer/windows): add wix installer #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 26, 2025

Description

This PR adds a WIX installer for Sunshine. The NSIS installer will be removed at a later point after any bugs with the WIX installer are ironed out.

This is a requirement for having an ARM64 installer for #3905 or #3369

TODO:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch 4 times, most recently from 14ce5ed to f20af0e Compare May 27, 2025 00:11
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@2259141). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3916   +/-   ##
=========================================
  Coverage          ?   11.37%           
=========================================
  Files             ?       92           
  Lines             ?    17549           
  Branches          ?     8232           
=========================================
  Hits              ?     1996           
  Misses            ?    13033           
  Partials          ?     2520           
Flag Coverage Δ
Linux-AppImage 11.09% <ø> (?)
Windows-AMD64 12.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

codecov bot commented May 27, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch 5 times, most recently from 9e4b955 to 6ef5e6e Compare May 27, 2025 02:01
Copy link

@cgutman
Copy link
Collaborator

cgutman commented Jun 13, 2025

The latest NSIS version now runs properly on ARM64 systems, so we can stick with NSIS if we want. WiX does make it easier to support having a single unified installer for both x64 and ARM64 binaries if we want that.

@ReenigneArcher
Copy link
Member Author

Good to know. I still need to setup a VM to test this out.

I think msi would still be nice to use, especially for anyone installing Sunshine with a script as it supports more CLI options. I discovered in a recent change that I couldn't even get the output of the installer scripts to a log file with NSIS.

Do you know the process for unifying the installer? That would be pretty nice.

@ReenigneArcher ReenigneArcher added this to the stable release milestone Jul 1, 2025
@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch 3 times, most recently from 6c352ab to f282e5d Compare July 4, 2025 02:35
@ReenigneArcher ReenigneArcher force-pushed the feat/installer/windows/add-wix-installer branch from f282e5d to 1e4a867 Compare July 4, 2025 03:33
Copy link

sonarqubecloud bot commented Jul 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunshine: change windows installer to WiX
2 participants