Skip to content

[FEATURE] Interface for vis geom. #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[FEATURE] Interface for vis geom. #1435

wants to merge 2 commits into from

Conversation

Kashu7100
Copy link
Collaborator

@Kashu7100 Kashu7100 commented Jul 19, 2025 •
edited by duburcqa
Loading

Description

Add get_pos and get_quat interface for RigidVisGeom to match with the RigidGeom interface to improve usability.

Checklist:

  • I read the CONTRIBUTING document.
  • I followed the Submitting Code Changes section of CONTRIBUTING document.
  • I tagged the title correctly (including BUG FIX/FEATURE/MISC/BREAKING)
  • I updated the documentation accordingly or no change is needed.
  • I tested my changes and added instructions on how to test it for reviewers.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@YilingQiao
Copy link
Collaborator

can you add a simple test? i.e. import and get the position of a box?

@duburcqa duburcqa changed the title [MISC] interface for vis geom [FEATURE] Interface for vis geom. Jul 19, 2025
@duburcqa duburcqa marked this pull request as draft July 22, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duburcqa duburcqa duburcqa approved these changes

@YilingQiao YilingQiao Awaiting requested review from YilingQiao YilingQiao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kashu7100 @YilingQiao @duburcqa