Skip to content

Boost: Mock Unrelated E2E Boost Prerequisites #44208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

LiamSarsfield
Copy link
Contributor

@LiamSarsfield LiamSarsfield commented Jul 7, 2025

Fixes HOG-200: Mock Unrelated Boost Prerequisites

Proposed changes:

Because E2E tests use localtunnel, it's suspected that Boost functionality such as Critical CSS Regen, and Page Speed scores, which are ran multiple times during the testing, is causing the localtunnel to be extremely slow to the point that Page Speed times out, and Critical CSS Regen may never complete. These changes ensure that that functionality is only ran where expected for the enabled E2E tests.

  • Mocks the Jetpack Boost Connection for E2E tests that were already enabled.
  • Ensure Mock speed scores is enabled for E2E tests that were already enabled.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Verify from the GitHub build that all tests passed.

If you want to test locally however:
From the projects/plugins/boost/tests/e2e directory:

Via ngrok (Recommended, but requires a subscription)

Replace $tunnel_url with your actual ngrok URL

  1. Install E2E test dependencies:

    pnpm install
  2. Start the Docker environment and tunnel:

    pnpm run env:up && TUNNEL_URL=$tunnel_url pnpm run tunnel:up
  3. Start your ngrok tunnel

    ngrok http --url=$tunnel_url http://localhost:8889/
  4. Run the specific re-enabled test suites:

     TUNNEL_URL=$tunnel_url pnpm run test: run specs/critical-css

Via localtunnel (Not recommended as it may be slow)

  1. Install E2E test dependencies:

    pnpm install
  2. Start the Docker environment and tunnel:

    pnpm run env:up && pnpm run tunnel:up
  3. Run the specific re-enabled test suites:

    pnpm run test:run specs/critical-css

Expected behavior:

  • All Enabled Boost E2E tests under GitHub actions should pass without skipping or timeout errors
  • Tests should pass consistently when run multiple times

Verification steps:

  1. Check that tests are running in CI:

    • The re-enabled test suites should appear in the E2E test matrix
    • CI should execute "Jetpack Boost - Modules"
  2. Test stability:

    • Run each test suite 3-5 times to ensure consistency
    • No intermittent failures or timing-related issues should occur

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress [Tests] Includes Tests Docker E2E Tests labels Jul 7, 2025
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 7, 2025
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@LiamSarsfield LiamSarsfield added [Type] Janitorial and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Jul 7, 2025
@github-actions github-actions bot added [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 7, 2025
@LiamSarsfield LiamSarsfield removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Jul 7, 2025
@LiamSarsfield LiamSarsfield requested review from dilirity, a team and kraftbj July 7, 2025 10:01
@LiamSarsfield LiamSarsfield marked this pull request as ready for review July 7, 2025 10:02
@LiamSarsfield LiamSarsfield added the [Status] Needs Review This PR is ready for review. label Jul 7, 2025
@kraftbj kraftbj merged commit f55b48d into trunk Jul 7, 2025
221 of 225 checks passed
@kraftbj kraftbj deleted the update/boost/e2e/mock-unrelated-testing-hog-200 branch July 7, 2025 20:40
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants