-
Notifications
You must be signed in to change notification settings - Fork 823
Boost: Mock Unrelated E2E Boost Prerequisites #44208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Mock Unrelated E2E Boost Prerequisites #44208
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Fixes HOG-200: Mock Unrelated Boost Prerequisites
Proposed changes:
Because E2E tests use localtunnel, it's suspected that Boost functionality such as Critical CSS Regen, and Page Speed scores, which are ran multiple times during the testing, is causing the localtunnel to be extremely slow to the point that Page Speed times out, and Critical CSS Regen may never complete. These changes ensure that that functionality is only ran where expected for the enabled E2E tests.
Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Verify from the GitHub build that all tests passed.
If you want to test locally however:
From the
projects/plugins/boost/tests/e2e
directory:Via ngrok (Recommended, but requires a subscription)
Replace
$tunnel_url
with your actual ngrok URLInstall E2E test dependencies:
Start the Docker environment and tunnel:
Start your ngrok tunnel
ngrok http --url=$tunnel_url http://localhost:8889/
Run the specific re-enabled test suites:
TUNNEL_URL=$tunnel_url pnpm run test: run specs/critical-css
Via localtunnel (Not recommended as it may be slow)
Install E2E test dependencies:
Start the Docker environment and tunnel:
pnpm run env:up && pnpm run tunnel:up
Run the specific re-enabled test suites:
Expected behavior:
Verification steps:
Check that tests are running in CI:
Test stability: