Skip to content

Boost: Re-enable Page Cache, Image Guide, Image CDN E2E tests #44210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LiamSarsfield
Copy link
Contributor

@LiamSarsfield LiamSarsfield commented Jul 7, 2025

Fixes HOG-199: Enable Image Guide E2E tests

Proposed changes:

This PR re-enables Page Cache, Image Guide, Image CDN E2E tests that was temporarily disabled in commit 0eb34d93ca7522549dcec7ea35c09d4f39ef5406 due to flakiness:

Re-enabled test suites:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Verify from the GitHub build that all tests passed.

If you want to test locally however:
From the projects/plugins/boost/tests/e2e directory:

Via ngrok (Recommended, but requires a subscription)

Replace $tunnel_url with your actual ngrok URL

  1. Install E2E test dependencies:

    pnpm install
  2. Start the Docker environment and tunnel:

    pnpm run env:up && TUNNEL_URL=$tunnel_url pnpm run tunnel:up
  3. Start your ngrok tunnel

    ngrok http --url=$tunnel_url http://localhost:8889/
  4. Run the specific re-enabled test suites:

     TUNNEL_URL=$tunnel_url pnpm run test: run specs/page-cache

Via localtunnel (Not recommended as it may be slow)

  1. Install E2E test dependencies:

    pnpm install
  2. Start the Docker environment and tunnel:

    pnpm run env:up && pnpm run tunnel:up
  3. Run the specific re-enabled test suites:

    pnpm run test:run specs/page-cache

Expected behavior:

  • All Common/Base tests should pass without skipping or timeout errors
  • Tests should pass consistently when run multiple times

Verification steps:

  1. Check that tests are running in CI:

    • The re-enabled test suites should appear in the E2E test matrix
    • CI should execute "Jetpack Boost - Page Cache"
    • CI should execute "Jetpack Boost - Image CDN"
    • CI should execute "Jetpack Boost - Image Guide"
  2. Test stability:

    • Run each test suite 3-5 times to ensure consistency
    • No intermittent failures or timing-related issues should occur

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress [Tests] Includes Tests Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests labels Jul 7, 2025
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 7, 2025
Copy link

jp-launch-control bot commented Jul 7, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@LiamSarsfield LiamSarsfield changed the title Boost: Re-add Page Cache, Image Guide, Image CDN E2E Tests Boost: Re-enable Page Cache, Image Guide, Image CDN E2E Tests Jul 7, 2025
@LiamSarsfield LiamSarsfield changed the title Boost: Re-enable Page Cache, Image Guide, Image CDN E2E Tests Boost: Re-enable Page Cache, Image Guide, Image CDN E2E tests Jul 7, 2025
@LiamSarsfield LiamSarsfield requested review from dilirity, kraftbj and a team July 7, 2025 13:21
@LiamSarsfield LiamSarsfield marked this pull request as ready for review July 7, 2025 13:22
Base automatically changed from update/boost/e2e/mock-unrelated-testing-hog-200 to trunk July 7, 2025 20:40
@github-actions github-actions bot added the Docker label Jul 7, 2025
@LiamSarsfield LiamSarsfield added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 8, 2025
@LiamSarsfield LiamSarsfield merged commit 5e859a4 into trunk Jul 9, 2025
71 checks passed
@LiamSarsfield LiamSarsfield deleted the update/boost/e2e/re-add-remaining-e2e-tests-hog-199 branch July 9, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docker E2E Tests I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants