Skip to content

parse_camera rendering bug #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
21220d1
add data field conversion for uint32 and commented back in ints 32 &64
nicolemarsaglia Mar 27, 2025
a87e34e
start of debugging. need to go into vtkm
nicolemarsaglia Mar 28, 2025
31095c9
merge with develop?
nicolemarsaglia Apr 3, 2025
ed01caf
add frustum debug
nicolemarsaglia Apr 8, 2025
8a56ba6
Merge branch 'develop' into task/2025_03_field_rendering_bug
nicolemarsaglia Apr 8, 2025
80666f8
update
nicolemarsaglia Apr 8, 2025
c4e1a6d
merge with dev
nicolemarsaglia Jun 4, 2025
b19fa78
change parse_camera order
nicolemarsaglia Jun 4, 2025
a5b69e2
Update Renderer.cpp
nicolemarsaglia Jun 4, 2025
0adb6c5
Update replay.cpp
nicolemarsaglia Jun 4, 2025
757f3e4
add some debugs and remove files that weren't supposed to be changed
nicolemarsaglia Jun 4, 2025
8df6fe0
Update Render.hpp
nicolemarsaglia Jun 4, 2025
a328f19
Merge branch 'develop' into task/2025_03_field_rendering_bug
nicolemarsaglia Jun 4, 2025
d29ed18
fix debug
nicolemarsaglia Jun 10, 2025
cd020d0
Merge branch 'develop' into task/2025_03_field_rendering_bug
nicolemarsaglia Jun 10, 2025
48294a6
idk why this got touched
nicolemarsaglia Jun 10, 2025
9ef241f
you shouldn't be here
nicolemarsaglia Jun 10, 2025
e6f5c1c
Update replay.cpp
nicolemarsaglia Jun 10, 2025
e8ea006
make the replay frustum its own thing
nicolemarsaglia Jun 10, 2025
ce2bd5f
check
nicolemarsaglia Jun 10, 2025
968d274
udpate baseline
nicolemarsaglia Jun 11, 2025
ab48dbc
Merge branch 'develop' into task/2025_03_field_rendering_bug
nicolemarsaglia Jun 18, 2025
9d291c3
update
nicolemarsaglia Jul 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix debug
nicolemarsaglia committed Jun 10, 2025
commit d29ed188bcb4cae8c447633649994781dee632e0
4 changes: 2 additions & 2 deletions src/libs/vtkh/rendering/Renderer.cpp
Original file line number Diff line number Diff line change
@@ -215,7 +215,7 @@ Renderer::DoExecute()

int total_renders = static_cast<int>(m_renders.size());

#ifdef _DEBUG
#if _DEBUG
std::cerr << "total renders: " << total_renders << std::endl;
vtkm::Bounds g_bounds = m_input->GetGlobalBounds();
std::cerr << "Global Bounds: " << std::endl;
@@ -260,7 +260,7 @@ Renderer::DoExecute()

Render::vtkmCanvas &canvas = m_renders[i].GetCanvas();
const vtkmCamera &camera = m_renders[i].GetCamera();
#ifdef _DEBUG
#if _DEBUG
std::cerr << "CAMERA BEFORE VTKM RENDERCELLS: " << std::endl;
camera.Print();
#endif