Skip to content

parse_camera rendering bug #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

nicolemarsaglia
Copy link
Contributor

the order we parse camera params matters

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
add some debug

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
add frustum to replay debug

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
this wasn't supposed to be this way
@cyrush
Copy link
Member

cyrush commented Jun 9, 2025

unhappy windows test case:

2025-06-05T00:26:18.0385228Z   Testing 3D Rendering with Default PipelineInvalid color table name 'blue'. Defaulting to cool to warm
2025-06-05T00:26:18.0385808Z   test_file: 
2025-06-05T00:26:18.0386102Z     path: "D:\\a\\ascent\\ascent\\build\\tests\\_output\\render_1100.png"
2025-06-05T00:26:18.0386453Z     exists: "true"
2025-06-05T00:26:18.0386645Z   baseline_file: 
2025-06-05T00:26:18.0386957Z     path: "D:\\a\\ascent\\ascent\\src\\tests\\_baseline_images\\render_1100.png"
2025-06-05T00:26:18.0387341Z     exists: "true"
2025-06-05T00:26:18.0387527Z   dims_match: "true"
2025-06-05T00:26:18.0387743Z   percent_diff: 0.727937519550323
2025-06-05T00:26:18.0387995Z   tolerance: 0.00999999977648258
2025-06-05T00:26:18.0388224Z   pass: "false"
2025-06-05T00:26:18.0388553Z   diff_image: "D:\\a\\ascent\\ascent\\build\\tests\\_output\\diff_render_1100.png"
2025-06-05T00:26:18.0388936Z   
2025-06-05T00:26:18.0389614Z D:\a\ascent\ascent\src\tests\ascent\t_ascent_render_3d.cpp(1956): error : Value of: check_test_image(output_file1, 0.01f) [D:\a\ascent\ascent\build\RUN_TESTS.vcxproj]
2025-06-05T00:26:18.0390312Z     Actual: false
2025-06-05T00:26:18.0390505Z   Expected: true
2025-06-05T00:26:18.0390684Z   
2025-06-05T00:26:18.0390948Z   [  FAILED  ] ascent_render_3d.test_render_3d_multi_render (353 ms)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix debug macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants