-
Notifications
You must be signed in to change notification settings - Fork 1
Port Standardization for Glance, Nova, NoVNC, Cinder and Neutron #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -11,7 +11,7 @@ default_store = file | |||
{% endif %} | |||
|
|||
bind_host = 0.0.0.0 | |||
bind_port = 9292 | |||
bind_port = 9393 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm just curious.. Why is this different than the value in defaults.yml
? Is one the keystone endpoint and the other haproxy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, one in default.yml is https port and haproxy binds to that (ssl terminates at haproxy). Other is actual service binding to. So here, 9292 if what haproxy will listen on for glance-api and forward that to actual glance-api service that binds to 9393 . Thus in glance-api.conf we telling it to bind to 9393 .... Net of all this is to have user facing apis with standard openstack ports (which terminates at haproxy).
In ICOS, we had haproxy running on different VM and thus did not have problem both the haproxy and actualy service both using same standard openstack port.
You've tested this right? Invoked all the CLIs? :) |
We need to also update the doc's where endpoints are documented. https://github.com/zrs233/ursula/blob/master/doc/endpoints.md |
We should figure out how they run tox (unit test). I see in ursula there is tox test. We should run that to ensure there is no regression. Otherwise looks good to me. 👍 |
|
I understand pull request is just to change ports.. However, we are using same ports in multiple places even across roles (like cinder and haproxy) All these port values would be good candidate to be added as variables in defaults.yml or "openstack" common cookbook maybe. |
No description provided.