Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifted from #19751 verbatim - thanks to @truemedian for the implementation 😅. That PR has been closed, and even though the larger effort around io has been subsumed by Andrew's writer refactoring, I didn't see this in the wrangle-writer-buffering branch. I decided it was probably ok to resurrect this bit of code.
I did spot-check the errors against the man pages and made sure all the listed errors in that page are present here - although I'll admit I don't truly grasp why some errors are marked as
unreachable
? I suppose we assume that this function will be called with proper arguments, and any issues around that will be caught in debug builds, where thoseunreachable
s will be printed with a stacktraceCloses #20660