Bluetooth: Classic: SDP: Improve SDP discovery response #93737
+268
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Classic
lylezhu2012
force-pushed
the
fix_sdp_discover_issue
branch
2 times, most recently
from
b7e65e0 to
6e7ba5d
Compare
In current implementation, the attribute of the registered SDP record will not be included in responding packet if the attribute data length is more than the MAX payload size(`MIN(SDP_MTU, sad->sdp->chan.tx.mtu) - sizeof(struct bt_sdp_hdr)`). And it causes the failure of ssa or sa discovery. Improve the SDP server to support the case by extending the continuation state length. A 4 bytes space is extended to store the attribute offset. In this way, the attribute can be transmitted in segments according to the reaming space of the responding buffer. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
fix_sdp_discover_issue
branch
from
6e7ba5d to
b8d0d2a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, the attribute of the registered SDP record will not be included in responding packet if the attribute data length is more than the MAX payload size (
MIN(SDP_MTU, sad->sdp->chan.tx.mtu) - sizeof(struct bt_sdp_hdr)). And it causes the failure of ssa or sa discovery.Improve the SDP server to support the case by extending the continuation state length. A 4 bytes space is extended to store the attribute offset.
In this way, the attribute can be transmitted in segments according to the reaming space of the responding buffer.