Skip to content

shell: Restore uninit_cb that was lost in #93154 #93690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

jeremybettis
Copy link
Contributor

The sh->ctx->uninit_cb needs to be set before posting the SHELL_SIGNAL_KILL to the event, like the k_poll based code did prior to

@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Shell Shell subsystem labels Jul 24, 2025
@zephyrbot zephyrbot requested review from carlescufi and jakub-uC July 24, 2025 22:41
The sh->ctx->uninit_cb needs to be set before posting the
SHELL_SIGNAL_KILL to the event, like the k_poll based code did prior to

Signed-off-by: Jeremy Bettis <[email protected]>
@jeremybettis jeremybettis changed the title Restore uninit_cb that was lost in #93154 shell: Restore uninit_cb that was lost in #93154 Jul 24, 2025
Copy link

@tristan-google tristan-google self-requested a review July 24, 2025 23:01
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, you may want to add an entry somewhere in the shell tests to catch this, seems uninit is not covered by tests

@keith-zephyr keith-zephyr added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Jul 25, 2025
@fabiobaltieri fabiobaltieri merged commit aab1dc6 into zephyrproject-rtos:main Jul 25, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shell Shell subsystem Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants