Revert "driver: serial: uart_ns16550: Add pm support for uart_ns16550 driver" #93568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… driver" This reverts commit fd88386, it breaks uart support on ITE platforms when PM is enabled but PM_RUNTIME is not, possibly others as well. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
requested review from
jhedberg,
jerome-pouiller,
Dino-Li,
dcpleung,
Martinhoff-maker,
GTLin08 and
keith-zephyr
fabiobaltieri
added
the
Trivial
fabiobaltieri
added
the
Regression
|
cc fimohame |
|
|
shouldnt you be filing a bug? |
1 task
Sure why not, added and linked. |
|
I also can't quite figure what the story was with the original change, the message is misleading, that commit does NOT enable pm device runtime support, it implements suspend as a no-op and resume as a reconfigure, a bit of context would have helped. |
bjarki-andreasen
approved these changes
Jul 23, 2025
fimohame
approved these changes
Jul 23, 2025
|
Update: this is broken on Realtek platforms as well |
keith-zephyr
approved these changes
Jul 23, 2025
fabiobaltieri
added
the
Hotfix
nashif
removed
the
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fd88386, it breaks uart support on ITE platforms when PM is enabled but PM_RUNTIME is not, possibly others as well.
I folks, this caused a regression downstream, I'd normally figure out a workaround and fix forward but something seems off so I'd ask you folks to rework this: seems like the implementation is a no-op for suspend and a reconfigure for resume, I've no doubt it works in your case but it doesn't for ITE, not entirely sure what breaks specifically but since ITE uses (sadly) system managed runtime this causes the uart to be reconfigued every time the CPU wakes up and there's no way of preventing it, so even if I figure how to make it cope with the continuous reconfiguration, I'd rather not do it in the first place.
fimohame@ could you rework this to add a property and only enable it on platforms that actually need it?
One more for #75963
Fixes #93572