drivers: counter: esp32: Fix alarm stops working #93538
Merged
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix condition in which alarm stops working after a certain amount of time. Hardware timer is 54-bit, yet it is treated as 32-bit by the counter driver. To allow alarm event by hardware comparators, counter high word must be loaded into the register along with the lower word managed by the driver. Signed-off-by: Raffael Rostagno <[email protected]>
|
zephyrbot
requested review from
LucasTambor,
marekmatej,
nordic-krch,
sylvioalves,
uLipe and
wmrsouza
uLipe
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Thanks for that @raffarost I was waiting for this fix for a long time 😊
sylvioalves
approved these changes
Jul 23, 2025
marekmatej
approved these changes
Jul 23, 2025
wmrsouza
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix condition in which alarm stops working after a certain amount of time. Hardware timer is 54-bit, yet it is treated as 32-bit by the counter driver. To allow alarm event by hardware comparators, counter high word must be loaded into the register along with the lower word managed by the driver.