samples: net: sockets: http_server: Dont block system workq #93537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the netstats handler calls on functions which reach deep into the networking stack, there is a lot of points actually at which it can be blocked, even forever. So having this handler on the system workqueue is not a good idea and can even cause a deadlock in some cases if it's blocked waiting on a synchronization primitive that would be given by a work item scheduled later in the queue. Therefore, make a workqueue specifically for this http server socket instead of using the system one. Signed-off-by: Declan Snyder <[email protected]>
zephyrbot
added
area: Samples
zephyrbot
requested review from
jukkar,
kartben,
mrodgers-witekio,
nashif and
rlubos
|
rlubos
approved these changes
Jul 23, 2025
mrodgers-witekio
approved these changes
Jul 23, 2025
jukkar
approved these changes
Jul 23, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the netstats handler calls on functions which reach deep into the networking stack, there is a lot of points actually at which it can be blocked, even forever. So having this handler on the system workqueue is not a good idea and can even cause a deadlock in some cases if it's blocked waiting on a synchronization primitive that would be given by a work item scheduled later in the queue. Therefore, make a workqueue specifically for this http server socket instead of using the system one.
Fixes #92652