-
Notifications
You must be signed in to change notification settings - Fork 7.7k
BMP581: Stream: Add FIFO Watermark Support #93166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kartben
merged 4 commits into
zephyrproject-rtos:main
from
CogniPilot:bmp581/fifo-wm-support
Jul 25, 2025
Merged
BMP581: Stream: Add FIFO Watermark Support #93166
kartben
merged 4 commits into
zephyrproject-rtos:main
from
CogniPilot:bmp581/fifo-wm-support
Jul 25, 2025
+321
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faa9f02
to
bba0620
Compare
teburd
previously approved these changes
Jul 17, 2025
bperseghetti
previously approved these changes
Jul 19, 2025
Otherwise it leads to potential incorrect expansions. Signed-off-by: Luis Ubieda <[email protected]>
Usually, drivers failing to initialize throw a message in the log, signaling the cause of failure. Add it to this driver so the user isn't confused by no message yet the device being marked as disabled. Signed-off-by: Luis Ubieda <[email protected]>
bba0620
to
967ce61
Compare
Waiting on resolution on #93624 to decide whether to leave the closing |
Configurable through dts property: fifo-watermark. Signed-off-by: Luis Ubieda <[email protected]>
Remove extra-parentheses when operator precedence is implicit. Eliminate implicit integer to boolean conversions. Signed-off-by: Luis Ubieda <[email protected]>
967ce61
to
db8c79d
Compare
In addition to optimizing the if-else, I added a separate patch to improve code-style in this module to remove extra-parentheses + remove implicit integer to boolean conversions. |
|
MaureenHelm
approved these changes
Jul 25, 2025
bperseghetti
approved these changes
Jul 25, 2025
teburd
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-on effort to #93130 in which FIFO Watermark support is added on top of Streaming, and is configurable through
fifo-watermark
DTS property.Testing