shell: exchange k_poll for k_event #93154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
force-pushed
the
shell-k_event
branch
from
3158f69 to
e5d91b3
Compare
pdgendt
reviewed
Jul 16, 2025
The shell subsystem currently uses k_poll for signalling. However,
k_poll is only used for simple event signals, results are not used.
Replacing the k_poll with k_event greatly simplifies the code, and
saves 4 struct k_poll_signal and 4 struct k_poll_event (one of which
was entirely unused) while costing a single struct k_event, for
every shell instance. It also allows us to not select POLL,
as we are using the simpler EVENTS instead.
A quick test build of the shell test suite on an nrf54l15 produces
the following build info:
using EVENTS:
FLASH: 71592 B 1428 KB 4.90%
RAM: 9872 B 188 KB 5.13%
IDT_LIST: 0 GB 32 KB 0.00%
using POLL
FLASH: 75524 B 1428 KB 5.16%
RAM: 11224 B 188 KB 5.83%
IDT_LIST: 0 GB 32 KB 0.00%
Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
shell-k_event
branch
from
e5d91b3 to
4021d9e
Compare
|
pdgendt
approved these changes
Jul 16, 2025
jakub-uC
approved these changes
Jul 22, 2025
| struct k_poll_signal *signal = | ||
| &sh->ctx->signals[SHELL_SIGNAL_KILL]; | ||
|
|
||
| sh->ctx->uninit_cb = cb; |
There was a problem hiding this comment.
What happened to this callback? It was lost.
jeremybettis
added a commit
to jeremybettis/zephyr
that referenced
this pull request
Jul 24, 2025
The sh->ctx->uninit_cb needs to be set before posting the SHELL_SIGNAL_KILL to the event, like the k_poll based code did prior to Signed-off-by: Jeremy Bettis <[email protected]>
jeremybettis
added a commit
to jeremybettis/zephyr
that referenced
this pull request
Jul 24, 2025
The sh->ctx->uninit_cb needs to be set before posting the SHELL_SIGNAL_KILL to the event, like the k_poll based code did prior to Signed-off-by: Jeremy Bettis <[email protected]>
fabiobaltieri
pushed a commit
that referenced
this pull request
Jul 25, 2025
The sh->ctx->uninit_cb needs to be set before posting the SHELL_SIGNAL_KILL to the event, like the k_poll based code did prior to Signed-off-by: Jeremy Bettis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell subsystem currently uses k_poll for signalling. However, k_poll is only used for simple event signals, results are not used.
Replacing the k_poll with k_event greatly simplifies the code, and saves 4 struct k_poll_signal and 4 struct k_poll_event (one of which was entirely unused) while costing a single struct k_event, for every shell instance. It also allows us to not select POLL, as we are using the simpler EVENTS instead.
A quick test build of the shell test suite on an nrf54l15 produces the following build info:
using EVENTS:
using POLL