bluetooth: mesh: removing gotten stuck persisted psa key if key id is reused #92780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth Mesh
platform: nRF BSIM
github-actions
bot
requested review from
aescolar,
akredalen,
Andrewpini,
HaavardRei,
jhedberg,
KyraLengfeld,
LingaoM,
omkar3141 and
PavelVPV
alxelax
force-pushed
the
robust_key_import
branch
from
93b03a2 to
370207c
Compare
omkar3141
reviewed
Jul 7, 2025
tests/bsim/bluetooth/mesh/tests_scripts/persistence/provisioning.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/mesh/tests_scripts/persistence/provisioning.sh
Outdated
Show resolved
Hide resolved
alxelax
force-pushed
the
robust_key_import
branch
from
370207c to
1863abd
Compare
omkar3141
previously approved these changes
Jul 8, 2025
PavelVPV
reviewed
Jul 24, 2025
tests/bsim/bluetooth/mesh/tests_scripts/persistence/provisioning.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/mesh/tests_scripts/persistence/provisioning.sh
Outdated
Show resolved
Hide resolved
Commit adds destruction of the persisted in PSA ITS key if mesh does not own it (zero bit in the bitmap of persisted keys). This is not standard mesh behavior, but might happen if something happens between removing key data in mesh and in the crypto library (for example power off in bettwen). Previously, mesh wasn't able to import key with gotten stuck key id. The current fix reproduces more robust behavior. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
robust_key_import
branch
from
1863abd to
c6ba81d
Compare
PavelVPV
previously approved these changes
Jul 24, 2025
Commit extends existing persistent provisioning bsim mesh test that checks that mesh removes gotten stuck persisted key if key is reused. Correct key is imported normally after that. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
robust_key_import
branch
from
c6ba81d to
fb417d1
Compare
|
PavelVPV
approved these changes
Jul 24, 2025
omkar3141
approved these changes
Jul 24, 2025
| # Test must be added in pair and in sequence. | ||
| # First test: saves data; second test: verifies it. | ||
| # | ||
| # Test procedure: |
There was a problem hiding this comment.
It is also bit new that we are now documenting the test procedure within the ".sh" file. This is not bad, but perhaps we should do this all tests eventually whenever we touch them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds destruction of the persisted in PSA ITS key if mesh does not own it (zero bit in the bitmap of persisted keys).
This is not standard mesh behavior, but might happen if something happens between removing key data in mesh and in the crypto library (for example, power off in between).
Previously, mesh wasn't able to import key with gotten stuck key ID. The current fix reproduces more robust behavior.
Additionally, PR extends the existing mesh persistent provisioning bsim test to emulate gotten stuck key and checking this key was destroyed, and correct one was imported instead.