Skip to content

drivers: flash: introduce nrf_mramc SHIM driver #91598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

drivers: flash: introduce nrf_mramc SHIM driver #91598

merged 1 commit into from
Jul 21, 2025

Conversation

travis3630
Copy link
Contributor

@travis3630 travis3630 commented Jun 13, 2025 •
edited
Loading

Add SHIM layer for nrfx_mramc driver for zephyr

https://github.com/nrfconnect/nrfx/pull/869 :: nrfx_mramc driver
nrfconnect/sdk-nrf#22801 -> nrfconnect/sdk-nrf#23240 (fixes) :: sdk-nrf mramc node nrf7120

@travis3630 travis3630 mentioned this pull request Jun 13, 2025
Merged
@travis3630 travis3630 marked this pull request as ready for review June 13, 2025 16:20
@travis3630 travis3630 force-pushed the WZN-4384-add-mramc-zephyr-driver branch 5 times, most recently from 370496d to f2524ad Compare June 20, 2025 13:23
@carlescufi carlescufi changed the title Wzn-4384 add mramc zephyr driver nordic: MRAMC driver Jul 3, 2025
@carlescufi carlescufi changed the title nordic: MRAMC driver flash: nordic: MRAMC driver Jul 3, 2025
@carlescufi
Copy link
Member

@rghaddab @de-nordic @bjarki-andreasen please review

@carlescufi carlescufi requested a review from hakonfam July 3, 2025 08:55
bjarki-andreasen
bjarki-andreasen requested changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit header needs a bit more info, something like

drivers: flash: nordic: introduce nrf_mramc or something

rghaddab
rghaddab reviewed Jul 3, 2025
View reviewed changes
Copy link
Contributor

@rghaddab rghaddab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in general.
Try adding more comments to explai some parts of the code that are not obvious. For example why are we giving as argument number of write_blocks etc.
Also change the commit message title. "drivers: flash" as a title is not acceptable

@travis3630 travis3630 mentioned this pull request Jul 3, 2025
Open
de-nordic
de-nordic requested changes Jul 3, 2025
View reviewed changes
@travis3630 travis3630 force-pushed the WZN-4384-add-mramc-zephyr-driver branch 3 times, most recently from c156088 to 9251ef4 Compare July 7, 2025 16:36
bjarki-andreasen
bjarki-andreasen requested changes Jul 8, 2025
View reviewed changes
@travis3630 travis3630 force-pushed the WZN-4384-add-mramc-zephyr-driver branch 4 times, most recently from 5ac94e7 to 6fe0410 Compare July 8, 2025 10:54
bjarki-andreasen
bjarki-andreasen reviewed Jul 8, 2025
View reviewed changes
@travis3630 travis3630 force-pushed the WZN-4384-add-mramc-zephyr-driver branch 2 times, most recently from 54fa86e to e2ae4a3 Compare July 9, 2025 14:43
@travis3630
Copy link
Contributor Author

@bjarki-andreasen @masz-nordic @de-nordic @rghaddab @carlescufi Still have more review to add? I have made all changes, pending for merge.

bjarki-andreasen
bjarki-andreasen previously approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@travis3630 travis3630 mentioned this pull request Jul 14, 2025
Merged
masz-nordic
masz-nordic reviewed Jul 15, 2025
View reviewed changes
@travis3630
drivers: flash: nordic: Introduce nrf_mramc driver
7f0a993 
Add SHIM layer for nrfx_mramc driver for zephyr

Signed-off-by: Travis Lam <[email protected]>
@travis3630 travis3630 force-pushed the WZN-4384-add-mramc-zephyr-driver branch from e2ae4a3 to 7f0a993 Compare July 15, 2025 16:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cfriedt cfriedt merged commit f94a45c into zephyrproject-rtos:main Jul 21, 2025
27 checks passed
@travis3630 travis3630 mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi carlescufi approved these changes

@masz-nordic masz-nordic masz-nordic approved these changes

@de-nordic de-nordic de-nordic approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@anangl anangl Awaiting requested review from anangl

@hubertmis hubertmis Awaiting requested review from hubertmis

@jaz1-nordic jaz1-nordic Awaiting requested review from jaz1-nordic

@kl-cruz kl-cruz Awaiting requested review from kl-cruz

@magp-nordic magp-nordic Awaiting requested review from magp-nordic

@nika-nordic nika-nordic Awaiting requested review from nika-nordic

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@hakonfam hakonfam Awaiting requested review from hakonfam

@rghaddab rghaddab Awaiting requested review from rghaddab

Assignees

@anangl anangl

@masz-nordic masz-nordic

@de-nordic de-nordic

Labels
area: Flash platform: nRF Nordic nRFx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@travis3630 @carlescufi @rghaddab @masz-nordic @de-nordic @bjarki-andreasen @cfriedt @anangl