GNSS RTK: Add basic integration #90890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubieda
commented
May 30, 2025
ubieda
force-pushed
the
gnss/rtk-integration
branch
5 times, most recently
from
e333b76 to
a7984f5
Compare
|
ubieda
commented
Jul 1, 2025
subsys/rtk/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Suggestion: Move to drivers/gnss/*
There was a problem hiding this comment.
Moved to subsys/gnss instead.
ubieda
force-pushed
the
gnss/rtk-integration
branch
2 times, most recently
from
9f187bf to
799ef56
Compare
ubieda
force-pushed
the
gnss/rtk-integration
branch
3 times, most recently
from
175d489 to
9e8bc2c
Compare
ubieda
force-pushed
the
gnss/rtk-integration
branch
from
9e8bc2c to
5a345fa
Compare
github-actions
bot
added
area: Base OS
github-actions
bot
requested review from
57300,
andyross,
bjarki-andreasen,
dcpleung and
fabiobaltieri
kartben
reviewed
Jul 20, 2025
kartben
reviewed
Jul 20, 2025
kartben
reviewed
Jul 20, 2025
kartben
reviewed
Jul 20, 2025
kartben
reviewed
Jul 20, 2025
Used in GNSS RTK correction frames. Signed-off-by: Luis Ubieda <[email protected]>
Validating both a frame without CRC (should return calculated CRC), and with CRC (should return 0 as a match). Signed-off-by: Luis Ubieda <[email protected]>
Incorporate the basic RTK API as well as a basic client integration (serial) as a way to receive and publish the RTK data. Signed-off-by: Luis Ubieda <[email protected]>
To be covered by existing Drivers: GNSS, as per requested during the review process. Added myself as a collaborator to follow-up with RTK-related changes. Signed-off-by: Luis Ubieda <[email protected]>
To capture framing capabilities (only API so far). Signed-off-by: Luis Ubieda <[email protected]>
So this API can be used to send frames with a different encoding than UBX. This enables UBX drivers to send RTCM3 correction frames using UBX API, without having to switch over modem pipes. Signed-off-by: Luis Ubieda <[email protected]>
Enable driver to consume RTK data-correction messages published in order to enhance GNSS Navigation results. Signed-off-by: Luis Ubieda <[email protected]>
Expand this sample to also work with GNSS_RTK through a serial client. Make this compatible to work with VMU_RT1170 which requires using the F9P, instead of the M8 UBX module. Signed-off-by: Luis Ubieda <[email protected]>
ubieda
dismissed stale reviews from bjarki-andreasen, bperseghetti, and fabiobaltieri
via
6045fcf
ubieda
force-pushed
the
gnss/rtk-integration
branch
from
f62d3db to
6045fcf
Compare
|
@kartben @fabiobaltieri please revisit |
|
fabiobaltieri
approved these changes
Jul 21, 2025
bperseghetti
approved these changes
Jul 21, 2025
kartben
approved these changes
Jul 21, 2025
bjarki-andreasen
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces RTK (Real Time Kinematics) to GNSS modems by providing a path to feed RTK correction data (proposed on #90363).
Detailed changes:
Note
Adding DNM until both conditions are resolved.