Refactor nordic socs/drivers to remove GPD and decouple pin retention. #90754
+1,107
−887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
from
afa9528 to
87e9f3a
Compare
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
from
f737ae0 to
8654ac9
Compare
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
2 times, most recently
from
95015ed to
1de2f64
Compare
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
12 times, most recently
from
3acab47 to
9163316
Compare
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
2 times, most recently
from
126e8cb to
3e4dca4
Compare
github-actions
bot
requested review from
anangl,
bbolen,
carlocaione,
galak,
jaz1-nordic,
kl-cruz and
magp-nordic
github-actions
bot
added
manifest
manifest-mcuboot
DNM (manifest)
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
from
12801a1 to
4477c75
Compare
github-actions
bot
removed
manifest
manifest-mcuboot
DNM (manifest)
bjarki-andreasen
changed the title
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
from
4477c75 to
2083028
Compare
masz-nordic
reviewed
Jul 24, 2025
| const struct nrf_port_retain_config *dev_config = dev->config; | ||
|
|
||
| LOG_DBG("%s pads 0x%08x retain %s", dev->name, dev_config->retain_mask, "enable"); | ||
| nrf_gpio_port_retain_enable(dev_config->regs, dev_config->retain_mask); |
There was a problem hiding this comment.
Nit: comment here with what is written in commit massage would be nice:
If no ACTIVE device is using any of the pads in the pad group, the pad groups power domain may be SUSPENDED. Before the pad groups power domain is SUSPENDED, pad config retention must be enabled to prevent the pads from loosing their state.
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
from
2083028 to
e2079fd
Compare
masz-nordic
previously approved these changes
Jul 24, 2025
Introduce the NRFS GDPWR (Global Domain Power Request) device driver and devicetree binding. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Introduce the NRF GPIO Pad Group device driver and binding. The pad group device represents the GPIO pads (pins), contrary to a GPIO controller, which is one of the many devices which can be muxed to pads in the pad group. The pad group belong to a power domain, which is not neccesarily the same power domain as devices being muxed to the pads, like GPIO or UART. If no ACTIVE device is using any of the pads in the pad group, the pad groups power domain may be SUSPENDED. Before the pad groups power domain is SUSPENDED, pad config retention must be enabled to prevent the pads from loosing their state. That's what this device driver manages. Once retained, the pad configs and outputs are locked, even when their power domain is SUSPENDED. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Transition nrf54h away from the soc specific gpd (global power domain) driver which mixed power domains, pinctrl and gpio pin retention into a non scalable solution, forcing soc specific logic to bleed into nrf drivers. The new solution uses zephyrs PM_DEVICE based power domains to properly model the hardware layout of device and pin power domains, and moves pin retention logic out of drivers into pinctrl and gpio, which are the components which manage pins (pads). Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Remove the deprecated GPD (Global Power Domain) driver. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
nrfs-swext-pd
branch
from
e2079fd to
fb766d7
Compare
|
Rebased to solve merge conflict |
|
ping @anangl @nika-nordic |
masz-nordic
approved these changes
Jul 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace highly coupled use of GPD (gpd.h) from device drivers, with power domain device drivers using zephyr's PM_DEVICE_POWER_DOMAIN infrastructure.
The gpd.h currently is used for two things:
Nordic device drivers currently have to do this manually, conditionally, which is adding immense complexity to them, only relevant for certain SoCs, and which is in theory duplicate code. In reality, device drivers do their best, but since gpd is not well understood, device drivers implement it slightly differently, in some cases working by design, some cases working by accident, and in some cases working, but breaking something else.
No more!
Both pin retention and power domains are actually designed in a way that is entirely logical, and can be expressed using power domains and the devicetree. So, using pinctrl and power domains, we can entirely decouple devices from this complexity :)
What does the refactor do?
power-domainsproperty from breaking user's applications if they "dare" to use zephyrs power domain framework. See first commit.