Skip to content

Add ManifestStore support for empty chunks. #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

Conversation

sharkinsspatial
Copy link
Collaborator

@sharkinsspatial sharkinsspatial commented Jul 10, 2025

  • Tests added
  • Tests passing
  • Full type hint coverage

Add support for ManifestStore to return None when reading "empty" chunks.

Closes #16

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (7dabefe) to head (80f0589).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #668      +/-   ##
===========================================
+ Coverage    78.30%   78.34%   +0.03%     
===========================================
  Files           34       34              
  Lines         1793     1796       +3     
===========================================
+ Hits          1404     1407       +3     
  Misses         389      389              
Files with missing lines Coverage Δ
virtualizarr/manifests/manifest.py 86.80% <100.00%> (+0.09%) ⬆️
virtualizarr/manifests/store.py 88.72% <100.00%> (+0.17%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones added this to the v2.0.0 milestone Jul 13, 2025
@maxrjones
Copy link
Member

All the failures are related to #673 so I'll go ahead and merge this.

@maxrjones maxrjones merged commit 3842634 into develop Jul 13, 2025
10 of 13 checks passed
@maxrjones maxrjones deleted the empty_chunks branch July 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are manifests with missing chunks valid?
2 participants