add controller id to the logger correctly #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
reviewed
Jul 9, 2025
controller/stackset.go
Outdated
| return &StackSetController{ | ||
| logger: log.WithFields(log.Fields{"controller": "stackset"}), | ||
| logger: log.WithFields(log.Fields{"controller": controllerID}), |
There was a problem hiding this comment.
I don't think it's the right field (controller should be kept as "stackset"). But we could add a second tag for the ID to solve your case.
There was a problem hiding this comment.
Hmm, makes sense. Will make it easier to differentiate it from other controllers running. I'll add another field.
There was a problem hiding this comment.
I added a second field conditionally, to avoid having to have controller_id="" in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
controllerfield in the logs currently has a hardcoded stringstackset. This isn't helpful when we define the optionalcontroller-idCLI parameter and run multiple controllers in a cluster for development/testing.This populates the field correctly with the
controllerIDif defined, and falls back tostacksetas the value when none is provided.