Skip to content

Improved Bottom Bar Responsiveness #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Improved Bottom Bar Responsiveness #19

merged 1 commit into from
Jun 27, 2018

Conversation

khanna98
Copy link
Member

No description provided.

@xeon-zolt
Copy link
Member

@khanna98 the bar moves to the top and the requirement is to make it stick at bottom of the page

screenshot_20180626_175549
screenshot_20180626_175526

Copy link
Member

@xeon-zolt xeon-zolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanna98 the nav bar should always be at the bottom of the page according to the current design
ThankYou

@khanna98
Copy link
Member Author

But this works fine on my browser ?!
screenshot_20180626_205628

@xeon-zolt
Copy link
Member

@gabru-md can you test ??
maybe some problem on my side

@xeon-zolt
Copy link
Member

@khanna98 can you attach screenshots in other screen sizes

@gabru-md
Copy link
Member

@khanna98 can you please provide us with a sample deployment on surge?
so that we can review and check if the problem persists 😄

@khanna98
Copy link
Member Author

screenshot_20180627_180306
This is the mobile view.

Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the changes are not very big. So I am merging this.
Incase any problem happens(which I hope will not), we will make a fix 😄

@gabru-md gabru-md merged commit 38b2f2e into yogdaan:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants