Skip to content

Documentation and pinning of packages #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added alternatives
vzaidman authored Oct 24, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit bb2b41dd6c94e584e3a4bc2d3177a95403998141
8 changes: 8 additions & 0 deletions accepted/0000-yarn-comments.md
Original file line number Diff line number Diff line change
@@ -105,6 +105,14 @@ JSON format. Making them adopt to the new one is defenetly a long shot. Also-
simply comments are weaker then this suggestion in terms of best practices like
single point of truth.

Adding a block to package.json- We might support this as well or instead of using
`yarn.comments`.

We can use a library to check version missmatches vs some file or vs a block in
`package.json` upon running different `yarn` (or even npm) scripts. This looks like
the fastest solution but it doesn't feel native. I want users to see the comments when
they run `yarn upgrade-interactive` near the packages in question for example.

# Unresolved questions

I considered to suggest to use `yarn.lock` for this at first but I want the user to