fix(core): detect packageManager field in manifest #3587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreialecu
force-pushed
the
feat-detectpmmanifest
branch
from
9b0c48f to
bc2ecef
Compare
merceyz
requested changes
Oct 18, 2021
andreialecu
force-pushed
the
feat-detectpmmanifest
branch
2 times, most recently
from
17f8b1e to
8af083c
Compare
andreialecu
force-pushed
the
feat-detectpmmanifest
branch
from
8af083c to
e1ae16d
Compare
paul-soporan
previously approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When packing git dependencies, yarn wouldn't take the
packageManagerproperty in the manifest into consideration.Discussed on Discord at https://discord.com/channels/226791405589233664/654372321225605128/899598848731799572
How did you fix it?
Updated
detectPackageManagerfunction to check the manifest.Checklist