-
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix: Added the RTL for the input-select #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances RTL support for the input-select
component, updates padding utilities to logical properties, and embeds a Base64 SVG for a pseudo-element background.
- Adds a
[dir="rtl"]
block to reposition the dropdown icon in RTL layouts - Replaces
pl
/pr
withps
/pe
in size-specific and base input-icon variants - Updates the
peer-checked:after
pseudo-element to use an inline Base64 SVG background
Comments suppressed due to low confidence (1)
src/components/inputs.scss:237
- [nitpick] Embedding a long inline Base64 SVG in the utility class increases bundle size and reduces readability. Consider extracting this icon into a dedicated asset or defining a custom Tailwind plugin/variable for reuse.
peer-checked:after:rounded-sm peer-checked:after:top-[-1px] peer-checked:after:left-[-1px] peer-checked:after:bg-[url('data:image/png;base64,PHN2Zy...')] peer-checked:after:h-5 peer-checked:after:w-5 peer-checked:after:content-[''] peer-checked:after:absolute
src/components/inputs.scss
Outdated
@@ -116,8 +116,12 @@ | |||
} | |||
|
|||
.input-select { | |||
@apply appearance-none outline-none h-11 bg-contrast hover:bg-contrast-800 focus:bg-contrast-900 border border-solid border-contrast-400 font-bold px-4 rounded-md text-base placeholder:font-normal placeholder:text-contrast-400 hover:border-secondary-500 focus:border-secondary transition-all disabled:opacity-70 [&:user-invalid]:border-danger [&:user-invalid]:hover:border-danger-500 [&:user-invalid]:focus:border-danger-900 [&:user-invalid]:text-danger disabled:cursor-not-allowed bg-no-repeat bg-right; | |||
@apply appearance-none outline-none h-11 bg-contrast hover:bg-contrast-800 focus:bg-contrast-900 border border-solid border-contrast-400 font-bold px-4 rounded-md text-base placeholder:font-normal placeholder:text-contrast-400 hover:border-secondary-500 focus:border-secondary transition-all disabled:opacity-70 [&:user-invalid]:border-danger [&:user-invalid]:hover:border-danger-500 [&:user-invalid]:focus:border-danger-900 [&:user-invalid]:text-danger disabled:cursor-not-allowed bg-[url('../icon-dropdown.svg')] bg-no-repeat bg-right ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @apply list now includes both a bg-[url(...)] utility and a subsequent background-image declaration (svg-load), which likely overrides the utility. Consider removing the redundant bg-[url] or reordering so only one method defines the background image.
@apply appearance-none outline-none h-11 bg-contrast hover:bg-contrast-800 focus:bg-contrast-900 border border-solid border-contrast-400 font-bold px-4 rounded-md text-base placeholder:font-normal placeholder:text-contrast-400 hover:border-secondary-500 focus:border-secondary transition-all disabled:opacity-70 [&:user-invalid]:border-danger [&:user-invalid]:hover:border-danger-500 [&:user-invalid]:focus:border-danger-900 [&:user-invalid]:text-danger disabled:cursor-not-allowed bg-[url('../icon-dropdown.svg')] bg-no-repeat bg-right ; | |
@apply appearance-none outline-none h-11 bg-contrast hover:bg-contrast-800 focus:bg-contrast-900 border border-solid border-contrast-400 font-bold px-4 rounded-md text-base placeholder:font-normal placeholder:text-contrast-400 hover:border-secondary-500 focus:border-secondary transition-all disabled:opacity-70 [&:user-invalid]:border-danger [&:user-invalid]:hover:border-danger-500 [&:user-invalid]:focus:border-danger-900 [&:user-invalid]:text-danger disabled:cursor-not-allowed bg-no-repeat bg-right ; |
Copilot uses AI. Check for mistakes.
background-image: svg-load('./icon-dropdown.svg'); | ||
[dir="rtl"] & { | ||
background-position: left 0.5rem center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Hardcoding 0.5rem
for RTL positioning may drift if padding scales change. Use a theme spacing variable or match the existing px-4
/ps-4
value (e.g., theme('spacing.4')
) to ensure alignment stays consistent.
Copilot uses AI. Check for mistakes.
Co-authored-by: David Négrier <[email protected]>
No description provided.