Skip to content

feat(Android): Implemented RNN link to work with kotlin instead of java and new versions of RNN #8044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gosha212
Copy link
Contributor

No description provided.

@gosha212 gosha212 linked an issue Jun 10, 2025 that may be closed by this pull request
1 task
@gosha212 gosha212 requested review from Copilot and d4vidi June 10, 2025 21:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates Android linking from Java to Kotlin and updates React Native Navigation support to work with RN 0.77. Key changes include replacing Java file references with Kotlin ones, updating default versions (Kotlin version and minSdkVersion), and modifying regex patterns and linking logic accordingly.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
autolink/postlink/path.js Updated glob patterns and exports to reference Kotlin files instead of Java files.
autolink/postlink/gradleLinker.js Updated default Kotlin version and minSdkVersion; removed Kotlin plugin dependency linking logic.
autolink/postlink/applicationLinker.js Switched from MainApplication.java to MainApplication.kt and added new architecture entry point removal.
autolink/postlink/activityLinker.js Changed references from Java to Kotlin and updated regex replacements for Kotlin syntax.
Test files & fixtures Updated test mocks and templates to reflect RN 0.77 and Kotlin syntax changes.
Comments suppressed due to low confidence (1)

autolink/postlink/gradleLinker.js:11

  • The property name 'setKlotinVersionSuccess' appears to be misspelled; consider renaming it to 'setKotlinVersionSuccess' for clarity and consistency.
this.setKlotinVersionSuccess = false;

@d4vidi d4vidi force-pushed the feat/7943-rn77-na-npx-rnn-link-is-outdated-aswell-as-a-documentation branch from 50220c8 to 61aff01 Compare June 12, 2025 08:20
@d4vidi d4vidi merged commit 8d9b6b0 into master Jun 12, 2025
4 checks passed
@d4vidi d4vidi deleted the feat/7943-rn77-na-npx-rnn-link-is-outdated-aswell-as-a-documentation branch June 12, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(RN77-NA) npx rnn-link is outdated aswell as a documentation
2 participants