Skip to content

Replace node-module 'tempfile' seamlessly with 'tmp' #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Jun 9, 2025

Description

(WIP) I've replaced tempfile with an internal util which uses tmp internally


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi self-assigned this Jun 9, 2025
@d4vidi
Copy link
Collaborator Author

d4vidi commented Jun 9, 2025

@noomorph, I could use a piece of advice about making tempfile.js easily accessible for usage outside detox/src/ (e.g. in local-cli/)

@d4vidi d4vidi force-pushed the chore/replace-tempfile branch from 75b4c7d to 72df738 Compare June 10, 2025 10:44
@d4vidi d4vidi marked this pull request as ready for review June 10, 2025 11:26
@d4vidi d4vidi requested a review from noomorph as a code owner June 10, 2025 11:26
Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, but I strongly advise to add one real test for tempfile.js which will be run in Github Actions environment, and make sure that our Windows coverage is ok.

@d4vidi d4vidi force-pushed the chore/replace-tempfile branch from 0c48646 to b0644ae Compare June 11, 2025 10:07
@d4vidi
Copy link
Collaborator Author

d4vidi commented Jun 11, 2025

@noomorph whenever you're ready

Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@d4vidi d4vidi merged commit 3fbd95d into master Jun 11, 2025
3 checks passed
@d4vidi d4vidi deleted the chore/replace-tempfile branch June 11, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace tempfile with something like tempy
2 participants