forked from BabDev/Pagerfanta
-
Notifications
You must be signed in to change notification settings - Fork 2
add mapping adapter #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yjv
wants to merge
7
commits into
whiteoctober:master
Choose a base branch
from
giftcards:mapping-adapter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add mapping adapter #195
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d1472d7
added the adapetrs adapter
bbb714f
added test for invalid callback
4f44c6f
made it so all traversable works too
aa347a2
made changes based on pr suggestions. changed the way the callback is…
a80d8d5
made changes based off pr
ea12155
removed unnecessary new line
09305ac
fixes based off pr
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Pagerfanta package. | ||
* | ||
* (c) Pablo Díez <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Pagerfanta\Adapter; | ||
|
||
class MappingAdapter implements AdapterInterface | ||
{ | ||
private $innerAdapter; | ||
private $callback; | ||
|
||
/** | ||
* @param AdapterInterface $innerAdapter | ||
* @param callable $callback | ||
*/ | ||
public function __construct(AdapterInterface $innerAdapter, $callback) | ||
{ | ||
if (!is_callable($callback)) { | ||
throw new \InvalidArgumentException('$callable must be callback'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you mean |
||
} | ||
|
||
$this->innerAdapter = $innerAdapter; | ||
$this->callback = $callback; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getNbResults() | ||
{ | ||
return $this->innerAdapter->getNbResults(); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getSlice($offset, $length) | ||
{ | ||
return call_user_func($this->callback, $this->innerAdapter->getSlice($offset, $length)); | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing new line after this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Pagerfanta package. | ||
* | ||
* (c) Pablo Díez <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Pagerfanta\Tests\Adapter; | ||
|
||
use Pagerfanta\Adapter\ArrayAdapter; | ||
use Pagerfanta\Adapter\MappingAdapter; | ||
|
||
class MappingAdapterTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
/** @var MappingAdapter */ | ||
protected $adapter; | ||
|
||
public function setUp() | ||
{ | ||
$this->adapter = new MappingAdapter(new ArrayAdapter(array( | ||
34, | ||
45, | ||
67, | ||
12 | ||
)), function (array $items) { | ||
return array_map( | ||
function ($item) { | ||
return $item + 1; | ||
}, | ||
$items | ||
); | ||
}); | ||
} | ||
|
||
public function testGetNbResults() | ||
{ | ||
$this->assertEquals(4, $this->adapter->getNbResults()); | ||
} | ||
|
||
public function testGetSlice() | ||
{ | ||
$this->assertEquals(array( | ||
35, | ||
46, | ||
68, | ||
13 | ||
), $this->adapter->getSlice(0, 34)); | ||
$this->assertEquals(array( | ||
35, | ||
46, | ||
), $this->adapter->getSlice(0, 2)); | ||
$this->assertEquals(array( | ||
68, | ||
13, | ||
), $this->adapter->getSlice(2, 5)); | ||
$this->assertEquals(array( | ||
68, | ||
), $this->adapter->getSlice(2, 1)); | ||
} | ||
|
||
/** | ||
* @expectedException \InvalidArgumentException | ||
*/ | ||
public function testConstructorWithNonCallableForCallback() | ||
{ | ||
new MappingAdapter(new ArrayAdapter(array()), 'bla'); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here:
callback t
=>callback to