-
Notifications
You must be signed in to change notification settings - Fork 126
Support unicode chars in annotations #20356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@biagas and/or @JustinPrivitera if you can take a brief look and lemme know what you think so far, that would be great. I am deciding what to do about 3D axes because they have a lot of custom coding. |
std::string fontFile = GetVisItResourcesDirectory(VISIT_RESOURCES_FONTS) + | ||
VISIT_SLASH_STRING; | ||
|
||
// Treat Arial as the "Regular" form of DejaVuSans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on what these comments mean? What is the regular/mono/serif form of DejaVu and why are they mapped to Arial, Courier, and Times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are different styles (behaviors) of fonts. Arial is a sans-serif (e.g. no serifs) font. Times is a serif font. Neither Arial or Times are "monospaced" (meaning columnar in that every character takes up the same space) like Courier which is often desired for displaying lines of code. My strong belief is that Arial, Times and Courier were used in VTK (long ago and still in our interface today) as recognizeable synonyms for those key font attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just seems odd to me to have synonyms instead of the real thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You asked what "regular/mono/serif" are. Does that suggest you are not as familiar with that font-speak? If so, don't fret. Most people don't. But, most people do know what Arial (or Helvetica), Times and Courier font faces are. I think that made sense for VTK way back when and I think it still probably makes sense in our GUI. Though, I could probably easily be convinced otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that suggest you are not as familiar with that font-speak?
That's right. Thanks for explaining! I don't have a strong opinion here.
Co-authored-by: Justin Privitera <[email protected]>
Co-authored-by: Justin Privitera <[email protected]>
Sorry, I misclicked and merged develop into this branch. Hope that's ok. |
Ok, I finally have a viable path for unicode in the axes titles... Screen.Recording.2025-05-06.at.4.51.03.PM.mov |
…av/visit into feat-mcm86-10apr25-unicode-fonts
…av/visit into feat-mcm86-10apr25-unicode-fonts
Description
Resolves #20350
Type of change
[ ] Bug fix[ ] Documentation update[ ] OtherHow Has This Been Tested?
Reminders:
Checklist: