Skip to content

Update the minimum version of React to use Fast Refresh #20016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update the minimum version of React to use Fast Refresh #20016

wants to merge 1 commit into from

Conversation

soilSpoon
Copy link

The minimum version of React to use Fast Refresh is 16.9
So update it.

Reference

facebook/react#16604 (comment)

@vercel vercel bot temporarily deployed to Preview December 9, 2020 12:30 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
buildDuration 9.7s 9.6s -56ms
nodeModulesSize 82.5 MB 82.5 MB -8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.315 2.307 -0.01
/ avg req/sec 1079.98 1083.69 +3.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.198 1.225 ⚠️ +0.03
/error-in-render avg req/sec 2086.52 2040.75 ⚠️ -45.77
Client Bundles (main, webpack, commons)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
buildDuration 11.3s 11.2s -72ms
nodeModulesSize 82.5 MB 82.5 MB -8 B
Client Bundles (main, webpack, commons)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 70d34d8

@ijjk
Copy link
Member

ijjk commented Dec 9, 2020

Failing test suites

Commit: 70d34d8

test/integration/cli/test/index.test.js

  • CLI Usage > start > too old of react version
  • CLI Usage > start > too old of react-dom version
Expand output

● CLI Usage › start › too old of react version

expect(received).toMatch(expected)

Expected substring: "Fast Refresh is disabled in your application due to an outdated `react` version"
Received string:    ""

  296 |       })
  297 | 
> 298 |       expect(stderr).toMatch(
      |                      ^
  299 |         'Fast Refresh is disabled in your application due to an outdated `react` version'
  300 |       )
  301 |       expect(stderr).not.toMatch(`react-dom`)

  at Object.<anonymous> (integration/cli/test/index.test.js:298:22)

● CLI Usage › start › too old of react-dom version

expect(received).toMatch(expected)

Expected substring: "Fast Refresh is disabled in your application due to an outdated `react-dom` version"
Received string:    ""

  315 |       })
  316 | 
> 317 |       expect(stderr).toMatch(
      |                      ^
  318 |         'Fast Refresh is disabled in your application due to an outdated `react-dom` version'
  319 |       )
  320 |       expect(stderr).not.toMatch('`react`')

  at Object.<anonymous> (integration/cli/test/index.test.js:317:22)

@soilSpoon soilSpoon force-pushed the feature/react-refresh branch from 70d34d8 to 7dde2f9 Compare December 9, 2020 12:50
@vercel vercel bot temporarily deployed to Preview December 9, 2020 12:50 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 9, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
buildDuration 8.5s 8.6s ⚠️ +81ms
nodeModulesSize 82.5 MB 82.5 MB -8 B
Page Load Tests Overall increase ✓
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.999 2.024 ⚠️ +0.02
/ avg req/sec 1250.66 1235.19 ⚠️ -15.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.09 1.065 -0.03
/error-in-render avg req/sec 2293.59 2347.05 +53.46
Client Bundles (main, webpack, commons)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
buildDuration 10.1s 10s -123ms
nodeModulesSize 82.5 MB 82.5 MB -8 B
Client Bundles (main, webpack, commons)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-899eb31..d9d9.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary soilSpoon/next.js feature/react-refresh Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 7dde2f9

Timer
Timer requested changes Dec 9, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite Fast Refresh working with 16.9, it works best with 16.10+, so we'll keep this suggestion as-is. Thanks!

@Timer Timer closed this Dec 9, 2020
@soilSpoon soilSpoon deleted the feature/react-refresh branch December 9, 2020 15:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer requested changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soilSpoon @ijjk @Timer