Store cleaned data and raw data when the excell file is imported. #188
+111
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamik
requested review from
domdinicola,
patsatsia,
sergey-misuk-valor and
vitali-yanushchyk-valor
domdinicola
approved these changes
Jul 30, 2025
domdinicola
approved these changes
Jul 30, 2025
datamik
force-pushed
the
feature/store-cleaned-data-when-importing-from-excel
branch
from
470e363 to
1a70a19
Compare
Update flex_fields with cleaned_data on every validation
datamik
force-pushed
the
feature/store-cleaned-data-when-importing-from-excel
branch
from
1a70a19 to
4528411
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #188 +/- ##
========================================
Coverage 95.53% 95.53%
========================================
Files 181 181
Lines 5757 5759 +2
Branches 521 521
========================================
+ Hits 5500 5502 +2
Misses 156 156
Partials 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| job.program.households.create( | ||
| batch=batch, | ||
| name=label, | ||
| Household.objects.create( |
There was a problem hiding this comment.
Maybe it will looks better?
batch.household_set.create(
name=str(label),
flex_fields=flex_fields,
raw_data=flex_fields,
),
vitali-yanushchyk-valor
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flex_fields with cleaned_data on every validation
https://dev.azure.com/unicef/ICTD-HCT-MIS/_workitems/edit/265154
Legal Boilerplate
Look, I get it.
Contributing to HOPE Workspace, I retain all rights, title and interest in and to my contributions, and by keeping
this boilerplate intact I confirm that HOPE Workspace can use, modify, copy, and redistribute my contributions,
under HOPE's choice of terms.