Skip to content

fix(jsx): list jsx-dev-runtime in package.json in files #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

octet-stream
Copy link
Contributor

@octet-stream octet-stream commented Jun 4, 2025

Changes Overview

Fixes #6389

This PR adds missing entry jsx-dev-runtime (introduced in #5558) to @tiptap/core package.

Implementation Approach

I have added jsx-dev-runtime to the files list in package.json. The directory is currently excluded from the distro because of it.

Testing Done

I did manual testing via npm publish --dry-run --tag next to make sure the directory is included in the output.

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: 4c4cdcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 4c4cdcc
🔍 Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/68407be807bfce0008ed3b19
😎 Deploy Preview https://deploy-preview-6414--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bdbch bdbch merged commit 0c1e100 into ueberdosis:next Jun 4, 2025
4 checks passed
@octet-stream octet-stream deleted the fix/jsx-runtime-missing-entry branch June 5, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to resolve import "@tiptap/core/jsx-dev-runtime"
2 participants