Skip to content

Make seed of min hasher repeatable #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tsdeng
Copy link
Contributor

@tsdeng tsdeng commented Oct 16, 2013

Use index of hash function as the seed of murmur hash

Currently, in MinHash we use randomGenerator to generate seed for murmurHash.

We want stable/repeatable behavior, so that
As long as the user provide the same parameter for constructing the monoid, the hash functions should be consistent

@sritchie
Copy link
Collaborator

Was it a bug that this wasn't the way it worked before?

@@ -63,16 +63,15 @@ abstract class MinHasher[H](val numHashes : Int, val numBands : Int)(implicit n
val numBytes = numHashes * hashSize
val numRows = numHashes / numBands

/** This seed could be anything */
private val seed = 123456789
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make the seed a param of the MinHasher constructor?

@ianoc
Copy link
Collaborator

ianoc commented Oct 17, 2013

@sritchie if the underling algo for the pusedo random numbers to scala changed then it would, otherwise it should be fine

@jnievelt
Copy link
Contributor

Would it be better to make this a separate type to avoid breaking compatibility with data stored from the existing version?

@ianoc ianoc closed this Aug 4, 2015
@ianoc
Copy link
Collaborator

ianoc commented Aug 4, 2015

Sorry my bad, git foo on cmd line broke stuff and closed all of these

@ianoc ianoc reopened this Aug 4, 2015
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ johnynek
❌ Sam Ritchie
❌ tsdeng


Sam Ritchie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants