Skip to content

[Breaking Change] Immunization Table addition from Input to Core layer #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: minor-release-v0.15
Choose a base branch
from
Open

[Breaking Change] Immunization Table addition from Input to Core layer #981

wants to merge 17 commits into from

Conversation

BijayaShres
Copy link
Contributor

Describe your changes

  • Introduction of a new clinical input layer table immunization
  • Transformation of the table to core__immunization
  • Introduction of 5 new terminology data set (needed to build core model)
    • terminology__act_site
    • terminology__cvx
    • terminology__immunization_route_code
    • terminology__immunization_status_reason
    • terminology__immunization_status
  • Relevant changes in integration_tests, docs_generate and ci_testing

How has this been tested?

Ran dbt build -s +core__immunization with different variation of variable combinations
Ran dbt build selectively in docs_generate and ci_testing as well

Reviewer focus

Please sync csvs for above terminologies from s3://tuva-public-resources-snowflake/versioned_terminology/ to s3://tuva-public-resources/versioned_terminology/0.15.0
Also, please sync branch release-v0.15.0-breaking-changes with latest Tuva main to see file changes clearly in the PR

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

@BijayaShres BijayaShres requested a review from sarah-tuva July 23, 2025 17:36
@BijayaShres BijayaShres added the breaking-change Changes have been made that may cause other components to fail label Jul 23, 2025
@github-project-automation github-project-automation bot moved this to 👀 Ready for Review in The Tuva Project Jul 23, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
1 similar comment
@github-actions GitHub Actions
Copy link

Workflow has finished with the following statuses:

  • Linter: success
  • BigQuery Clinical and Claims: failure
  • BigQuery Claims: skipped
  • BigQuery Clinical: skipped
  • Fabric Clinical and Claims: failure
  • Fabric Claims: skipped
  • Fabric Clinical: skipped
  • Redshift Clinical and Claims: failure
  • Redshift Claims: skipped
  • Redshift Clinical: skipped
  • Snowflake Clinical and Claims: failure
  • Snowflake Claims: skipped
  • Snowflake Clinical: skipped

@github-actions GitHub Actions
Copy link

Workflow has finished with the following statuses:

  • Linter: success
  • BigQuery Clinical and Claims: success
  • BigQuery Claims: success
  • BigQuery Clinical: success
  • Fabric Clinical and Claims: success
  • Fabric Claims: success
  • Fabric Clinical: success
  • Redshift Clinical and Claims: success
  • Redshift Claims: success
  • Redshift Clinical: success
  • Snowflake Clinical and Claims: success
  • Snowflake Claims: success
  • Snowflake Clinical: success

sarah-tuva
sarah-tuva requested changes Jul 29, 2025
View reviewed changes
Copy link
Member

@sarah-tuva sarah-tuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BijayaShres, thanks for opening this new PR. Apologies for the delay in reviewing it. I just ran the CI tests and they're all passing.

I have two requests for changes. Can you take a look at the data marts listed below. This new data source needs to be added to both. Let me know if you have any questions.

@BijayaShres
Copy link
Contributor Author

BijayaShres commented Jul 30, 2025 •
edited
Loading

Hi @sarah-tuva ! Thanks for reviewing the PR and running the CI tests.

I'll update both the dqi and normalize data marts to include the new data source.
Furthermore, i will also work on updating the docs docs related to normalize mart.
Let me know if there's anything else I should keep in mind.

@sarah-tuva
Copy link
Member

@BijayaShres, good idea to update docs for normalize. 🙏 Can you also create PR adding this new file type to Docs? I think we will want it in the Input Layer and Core sections.

krishyfishy and others added 12 commits August 1, 2025 09:37
@krishyfishy
Add missing input layer fields (tuva-health#1005)
006a5ab 
update yml
@BijayaShres
Merge branch 'minor-release-v0.15' into immunizationtable
6c42ed7
@amartinson193
Update pull_request_template.md
4daf6ba
@sarah-tuva
Update github workflows: add better concurrency and remove push trigg…
2dd1e85 
…er (tuva-health#1003)

* remove push trigger

* add logic to concurrency group

* fix concurrency logic
@sarah-tuva
Provider update for July 2025 (tuva-health#1011)
5bc4a7a 
update seed path version
@sarah-tuva
Patch release v0.14.18 (tuva-health#1012)
4814295 
update package version and seed paths
@krishyfishy
Update HCPCS code test, add threshold for PMPM (tuva-health#1008)
2d009e8 
* update hcpcs code test, add threshold for PMPM

* update test and severity level

* update test config

* fabric
@chase-jones
Merge branch 'main' into amartinson193-patch-1
d4397aa
@krishyfishy
Point terminology meta configs to docs instead of GitHub (tuva-health…
6468480 
…#1014)

* fix links

* trim whitespace
@amartinson193
Merge pull request tuva-health#1007 from tuva-health/amartinson193-pa…
8defa1d 
…tch-1

Update pull_request_template.md
@BijayaShres
Merge branch 'main' of https://github.com/BijayaShres/tuva-health-tuva …
228169b 
…into immunizationtable
@BijayaShres
feat:add immunization table to dql mart
df28532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-tuva sarah-tuva sarah-tuva requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@sarah-tuva sarah-tuva

Labels
breaking-change Changes have been made that may cause other components to fail
Projects
The Tuva Project
Status: 👀 Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BijayaShres @sarah-tuva @utsavpaudel @krishyfishy @amartinson193 @chase-jones