-
Notifications
You must be signed in to change notification settings - Fork 96
Move some testing from older dqi into newer dqi #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivy-tuva
wants to merge
48
commits into
main
Choose a base branch
from
830-move-some-testing-from-older-dqi-into-newer-dqi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move some testing from older dqi into newer dqi #966
ivy-tuva
wants to merge
48
commits into
main
from
830-move-some-testing-from-older-dqi-into-newer-dqi
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ccd5a53.
❌ SQLFluff Linting Failed Issues were found that require manual correction or are unfixable by
|
…ttps://github.com/tuva-health/tuva into 830-move-some-testing-from-older-dqi-into-newer-dqi
…ork for clinical CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
-Problem: dbt_expectations does not support Fabric. For every macro in dbt_expectations_tests, sql logic for Fabric was added if it was missing. This logic was written to mimic the dbt_expectations tests.
-Moved dbt_expectations_tests under tests/generic because it needs to be here or under macros in order to reference the tests in other files.
How has this been tested?
This was tested locally for Snowflake and BigQuery. Waiting on Redshift access and troubleshooting Fabric connection issues in dbt core.
Reviewer focus
Checklist before requesting a review
tuva_last_run
to the final output(Optional) Gif of how this PR makes you feel
Loom link