Skip to content

Adding plan overlap test #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding plan overlap test #1006

wants to merge 2 commits into from

Conversation

amartinson193
Copy link
Contributor

Describe your changes

Adding a new test to ensure most of the plans overlap between medical, eligibility, and pharmacy.

How has this been tested?

Ran on client's data.

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

@amartinson193 amartinson193 added the enhancement New feature or request label Aug 4, 2025
@github-project-automation github-project-automation bot moved this to 👀 Ready for Review in The Tuva Project Aug 4, 2025
Copy link

github-actions bot commented Aug 4, 2025

SQLFluff Linting Failed

Issues were found that require manual correction or are unfixable by sqlfluff fix.
Please review the output below (or the full logs), fix the issues locally, and commit the changes.

SQLFluff Run Log - Mode: ci, Fix: false, Time: Mon Aug  4 17:49:55 UTC 2025

===== SQLFLUFF LINT (Initial Check) OUTPUT (2025-08-04_17:54:35) (Filtered) =====

=== [dbt templater] Sorting Nodes...
=== [dbt templater] Compiling dbt project...
=== [dbt templater] Project Compiled.
== [tests/check_plan_overlap.sql] FAIL
L:  13 | P:  11 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  14 | P:  13 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  15 | P:  94 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  16 | P:  92 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  22 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  24 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  28 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  30 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  34 | P:   7 | AL01 | Implicit/explicit aliasing of table. [aliasing.table]
L:  36 | P:   2 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  39 | P:  11 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  40 | P:  13 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  41 | P:  26 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  42 | P:  25 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
All Finished!

=========================================================================


===== SQLFLUFF FIX (Check, Informational) OUTPUT (2025-08-04_17:59:20) (Filtered) =====

==== finding fixable violations ====
=== [dbt templater] Sorting Nodes...
=== [dbt templater] Compiling dbt project...
=== [dbt templater] Project Compiled.
== [tests/check_plan_overlap.sql] FAIL
L:  13 | P:  11 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  14 | P:  13 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  15 | P:  94 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  16 | P:  92 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  22 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  24 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  28 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  30 | P:   1 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  34 | P:   7 | AL01 | Implicit/explicit aliasing of table. [aliasing.table]
L:  34 | P:   7 | CP01 | Keywords must be lower case. [capitalisation.keywords]
L:  36 | P:   2 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  39 | P:  11 | LT01 | Unnecessary trailing whitespace. [layout.spacing]
L:  40 | P:  13 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  41 | P:  26 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
L:  42 | P:  25 | LT04 | Found trailing comma ','. Expected only leading near
                       | line breaks. [layout.commas]
== [tests/check_plan_overlap.sql] FIXED
15 fixable linting violations found

=========================================================================

@amartinson193
Copy link
Contributor Author

@chase-jones This is ready for review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants