feat: support codemod for individual lodash package imports #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
commented
Jun 15, 2025
Comment on lines
+119
to
+153
| // import sortBy from 'lodash.sortby' → import sortBy from 'es-toolkit/compat/sortby' | ||
| function transformLodashIndividualPackages(root: Collection, j: JSCodeshift): boolean { | ||
| const lodashIndividualImports = root.find(j.ImportDeclaration).filter((path) => { | ||
| const source = path.node.source.value; | ||
| if (typeof source !== 'string' || !source.startsWith('lodash.')) { | ||
| return false; | ||
| } | ||
|
|
||
| const packageName = source.replace('lodash.', ''); | ||
| return lodashFunctionsLowerCaseToOriginalMap.has(packageName); | ||
| }); | ||
|
|
||
| if (lodashIndividualImports.length === 0) { | ||
| return false; | ||
| } | ||
|
|
||
| lodashIndividualImports.replaceWith((path) => { | ||
| const { node } = path; | ||
| const modulePath = node.source.value as string; | ||
| const lowercaseFunctionName = modulePath.replace('lodash.', ''); | ||
| const originalFunctionName = lodashFunctionsLowerCaseToOriginalMap.get(lowercaseFunctionName); | ||
|
|
||
| if (node.specifiers?.[0]?.local && originalFunctionName) { | ||
| const localIdentifier = node.specifiers[0].local; | ||
|
|
||
| return j.importDeclaration( | ||
| [j.importDefaultSpecifier(localIdentifier)], | ||
| j.literal(`es-toolkit/compat/${originalFunctionName}`), | ||
| ); | ||
| } | ||
| return node; | ||
| }); | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
in #7, this files at test directory
but it works with lowercased, so I moved here
This was referenced Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6
only changes at 870141c (between #7)
handling individual lodash packages (like
lodash.sortby)