-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore(ci): tweak merge script to have less conflicts and output to be more readable #10452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
131a1b4 to
a743a93
Compare
a743a93 to
11fbb3d
Compare
| scripts/ci/templates/changelog_master.xml merge=merge_changelog | ||
|
|
||
| app-metadata/com.fsck.k9/*/changelogs/** merge=merge_changelog | ||
| app-metadata/net.thunderbird.android.beta/*/changelogs/** merge=merge_changelog No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to add this one too:
app-metadata/net.thunderbird.android/*/changelogs/** merge=merge_changelog
| app-thunderbird/build.gradle.kts merge=merge_gradle | ||
| app-k9mail/src/main/res/raw/changelog_master.xml merge=ours | ||
|
|
||
| app-k9mail/src/main/res/raw/changelog_master.xml merge=merge_changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want to add this one too:
./app-thunderbird/src/release/res/raw/changelog_master.xml
It only exists in the release branch but to be safe we don't want to overwrite it.
| app-k9mail/src/main/res/raw/changelog_master.xml merge=merge_changelog | ||
| app-thunderbird/src/debug/res/raw/changelog_master.xml merge=merge_changelog | ||
| app-thunderbird/src/daily/res/raw/changelog_master.xml merge=merge_changelog | ||
| scripts/ci/templates/changelog_master.xml merge=merge_changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 can can be removed. It should be fine to overwrite what's in beta/release with what is in main:
app-thunderbird/src/debug/res/raw/changelog_master.xml merge=merge_changelog
app-thunderbird/src/daily/res/raw/changelog_master.xml merge=merge_changelog
scripts/ci/templates/changelog_master.xml merge=merge_changelog
This patch does two things:
Tells git to default to a "theirs" strategy when there are merge conflicts (i.e. in a main -> beta merge conflict, take the file from main).
Highlight "CONFLICT" in red, so it can be easily spotted in
git mergeoutput.