Skip to content

format: update ruff #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Conversation

gbaian10
Copy link
Contributor

@gbaian10 gbaian10 commented Apr 6, 2025

Checklist

  • Discussed idea or confident it's critical (See Contribute.md).
  • One feature/bug per PR (unless minor/related).
  • PR is from a feature branch, not main.
  • I ran at least one example to ensure the code works.
  • Checked linting/formatting (uv run ruff format && uv run ruff check).

Description

In PR #136, #144, and #149, there were issues with CI not passing.

Ruff updated its format rules in version 0.9.0.

The CI didn't specify the Ruff version, which caused it to download the latest version.
However, the version in uv.lock is fixed at 0.8.6, leading to differences between local Ruff format execution and the CI results.

@gbaian10
Copy link
Contributor Author

gbaian10 commented Apr 6, 2025

image

@thewh1teagle
Copy link
Owner

I tried many times to fix it and wasn't sure why it failed in CI
Thank you!

@thewh1teagle thewh1teagle merged commit 2408a69 into thewh1teagle:main Apr 6, 2025
1 check passed
@gbaian10 gbaian10 deleted the update_ruff branch April 7, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants